Update the Dockerfile to use downstream images #6
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
openshift-ci
bot
added
the
approved
|
@timflannagan: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
| return nil, err | ||
| } | ||
| if bi.Status.InstalledBundleName == "" { | ||
| if bi.Status.ActiveBundle == "" { |
There was a problem hiding this comment.
Is this supposed to come along?
There was a problem hiding this comment.
Yep, but I had sneaked it in. My IDE was complaining about it locally.
There was a problem hiding this comment.
Yes, I think it's ok -- we changed the name of that field upstream and it probably never got updated in the e2e test on the PO side.
| return nil, err | ||
| } | ||
| if bi.Status.InstalledBundleName == "" { | ||
| if bi.Status.ActiveBundle == "" { |
There was a problem hiding this comment.
Yes, I think it's ok -- we changed the name of that field upstream and it probably never got updated in the e2e test on the PO side.
| io.k8s.description="This is a component of OpenShift Container Platform and manages the lifecycle of platform operators." \ | ||
| io.openshift.tags="openshift" \ | ||
| summary="This is a component of OpenShift Container Platform and manages the lifecycle of platform operators." \ | ||
| maintainer="Odin Team <aos-odin@redhat.com>" |
There was a problem hiding this comment.
nit: can we update this to a more recent email? We could use the olm dev working group email.
That email is set up from Evan and I'm not sure the current status of who is monitoring it.
There was a problem hiding this comment.
Yep, just a copy/paste error. We'll have this issue across multiple repos, so probably best to update it uniformly.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: exdx, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Update dockerfile and use the rhel-related base images. Run the build Makefile target in the builder image and copy that PO manager executable into the final image layer.