OCPBUGS-1456: Ensure components can pass openshift conformance tests #61
Conversation
Signed-off-by: timflannagan <timflannagan@gmail.com>
…ce + CRDs to related objects Signed-off-by: timflannagan <timflannagan@gmail.com>
…as a related object Signed-off-by: timflannagan <timflannagan@gmail.com>
Signed-off-by: timflannagan <timflannagan@gmail.com>
|
@timflannagan: This pull request references Jira Issue OCPBUGS-1456, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
jira/invalid-bug
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@timflannagan: This pull request references Jira Issue OCPBUGS-1456, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/payload 4.12 nightly informing |
|
@timflannagan: trigger 49 job(s) of type informing for the nightly release of OCP 4.12
See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f0d5d3f0-3839-11ed-8e0c-d58ae1444121-0 |
| limits: | ||
| cpu: 500m | ||
| memory: 128Mi |
There was a problem hiding this comment.
Note: we have conformance tests that verify component pods don't specify limits, and don't get assigned the BestEffort quality of service. Removing the limits resulted in the Burstable QoS being assigned to these pods.
| runAsNonRoot: true | ||
| seccompProfile: | ||
| type: RuntimeDefault | ||
| priorityClassName: "system-cluster-critical" |
There was a problem hiding this comment.
Note: just mirroring what's defined for OLM sub-components here.
| resources: | ||
| requests: | ||
| cpu: 1m | ||
| memory: 15Mi |
There was a problem hiding this comment.
Note: these requests are for the kube-rbac-proxy sidecar container. I modeled these after what cluster monitoring have defined for their deployments that utilize kube-rbac-proxy.
| resources: | ||
| requests: | ||
| cpu: 15m | ||
| memory: 100Mi |
There was a problem hiding this comment.
This is for the core rukpak deployment. I increased the memory request to 100Mi just because we're caching bundle contents in-memory, so we may want to invest in benchmarking this behavior to get a better read on what kind of requests we need to be setting for subsequent phases.
| - group: core.rukpak.io | ||
| name: "" | ||
| resource: bundles | ||
| - group: core.rukpak.io | ||
| name: "" | ||
| resource: bundledeployments |
There was a problem hiding this comment.
Prior to GA, I think we should separate out the rukpak stuff from the PO stuff. At the end of the day, PO will depend on rukpak, not provide it.
But this is fine in the mean time.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: joelanford, timflannagan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@timflannagan: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-1456 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
See https://issues.redhat.com/browse/OCPBUGS-1456 for more information.
Adds the openshift-platform-operators system namespace and the CRDs for platform operators/rukpak to the related objects array. Ensures the Pods that get deployed by the CVO follow any openshift conventions defined as conformance tests.