Skip to content

Conversation

timflannagan
Copy link
Contributor

Ensure golangci-lint can successfully run when deployed in the CI
cluster environments by overriding the default cache directory location
to a writable directory (e.g. /tmp).

Signed-off-by: timflannagan timflannagan@gmail.com

Ensure golangci-lint can successfully run when deployed in the CI
cluster environments by overriding the default cache directory location
to a writable directory (e.g. /tmp).

Signed-off-by: timflannagan <timflannagan@gmail.com>
@timflannagan
Copy link
Contributor Author

@openshift-ci openshift-ci bot requested review from exdx and tylerslaton August 4, 2022 22:03
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: timflannagan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

@timflannagan: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@timflannagan
Copy link
Contributor Author

Continuing to burn down CI failures from openshift/release#31085. This should just need a lgtm.

@tylerslaton
Copy link
Contributor

Nice!

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@openshift-ci openshift-ci bot merged commit 01e6122 into openshift:main Aug 5, 2022
@timflannagan timflannagan deleted the ci/fix-unit-cache-permissions branch August 5, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants