Add Cilium #17380
Add Cilium #17380
Conversation
|
Hi @errordeveloper. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
needs-ok-to-test
|
copying from slack thread Templates are deprecates, so ideally this would be converted into steps. I think the best here would be:
In order to test this you could add a periodic job which runs this workflow |
errordeveloper
changed the title
|
@vrutkovs I had a look around and figured that'd base this on structure similar to e.g. OVN rather then Loki, PTAL! |
|
/ok-to-test |
openshift-ci-robot
added
ok-to-test
openshift-ci-robot
added
the
do-not-merge/invalid-owners-file
|
AWS install is pretty strict about open ports, lets try |
|
@vrutkovs it definitely makes sense to prioritise Azure and make sure things work overall! I'll happily leave UPI and opening ports in GCP and AWS for another PR ;) |
...tep-registry/openshift/e2e/gcp/cilium/default/openshift-e2e-gcp-cilium-default-workflow.yaml
Outdated
Show resolved
Hide resolved
|
Lets add a new periodic (see https://github.com/openshift/release/pull/17519/files#diff-53da59c71bd31de3834afc38a2ccc62bf85595cb1546630ce3a10d4bfe6fe695) to have this rehearsed in CI (use |
|
@vrutkovs once I add the periodic, will only run once the changes are merged, or it can be rehearsed from the PR branch somehow? |
CI bot would add |
openshift-ci-robot
removed
the
do-not-merge/invalid-owners-file
errordeveloper
force-pushed
the
cilium
branch
3 times, most recently
from
25a9239 to
605a30c
Compare
|
Closed accidentally, re-opening. |
Looks like these are flakes, neither have failed on the last attempt. |
|
Looks like after renaming there is old rehearsal job still lurking around: |
|
@vrutkovs I think this is actually good now, how do we go about the flakes? I'll squash the commits also. |
- define steps and workflows for aws, azure & gcp - define periodic job only for azure (gcp & aws will require some solution for Cilium ports)
|
I think we're good with leaving the flakes for now - we'll squash those after a few rounds of tests. Lets update the description - why Azure, what this PR does (adds steps / workflows and a single periodic for 4.8) along with future plans. /cc @deads2k @smarterclayton for review |
|
@vrutkovs: GitHub didn't allow me to request PR reviews from the following users: for, review. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@vrutkovs: GitHub didn't allow me to request PR reviews from the following users: for, parts. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
errordeveloper
changed the title
|
@errordeveloper: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Looks like only one failure in the latest run: |
| cpu: 100m | ||
| memory: 100Mi | ||
| documentation: |- | ||
| This steps sets `networkType: None` and disables `cluster-network-operator` (CNO) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: errordeveloper, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@errordeveloper: Updated the following 3 configmaps:
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR adds steps and workflows to enable testing with Cilium.
Steps and workflows are defined aws, azure & gcp. As Cilium requires additional ports, only an azure periodic is being added here for 4.8. Peridics for gcp & aws should be added in the future, but something will have to be done about Cilium ports.