Skip to content

Fix numericCompareTo() #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yutaro-sakamoto merged 1 commit into from
Oct 22, 2024
Merged

Fix numericCompareTo() #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/data/CobolNumericField.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ public int numericCompareTo(AbstractCobolField field) {
final int i1 = firstIndex1 + i + pointIndex1;
final int i2 = firstIndex2 + i + pointIndex2;
byte b1;
if (i1 < 0 || i1 > lastIndex1) {
if (i1 < firstIndex1 || i1 > lastIndex1) {
b1 = (byte) '0';
} else {
b1 = d1.getByte(i1);
Expand All @@ -920,7 +920,7 @@ public int numericCompareTo(AbstractCobolField field) {
}
}
byte b2;
if (i2 < 0 || i2 > lastIndex2) {
if (i2 < firstIndex2 || i2 > lastIndex2) {
b2 = (byte) '0';
} else {
b2 = d2.getByte(i2);
Expand Down
31 changes: 31 additions & 0 deletions tests/misc.src/compare-9.at
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,3 +57,34 @@ AT_CHECK([${COBJ} prog.cbl])
AT_CHECK([java prog])

AT_CLEANUP

AT_SETUP([compare 9(n), S9(n) SEPARATE])

AT_DATA([prog.cbl], [
IDENTIFICATION DIVISION.
PROGRAM-ID. prog.
DATA DIVISION.
WORKING-STORAGE SECTION.
01 N10 PIC 9(10).
01 S9-L PIC S9(9) SIGN LEADING SEPARATE.
01 S9-T PIC S9(9) SIGN TRAILING SEPARATE.
PROCEDURE DIVISION.
MAIN-PROC.
*************************************************************
MOVE 800 TO N10.
MOVE 900 TO S9-L.
MOVE 900 TO S9-T.

IF N10 >= S9-L
DISPLAY "NG (N10 >= S9-L)"
END-IF.

IF N10 >= S9-T
DISPLAY "NG (N10 >= S9-T)"
END-IF.
])

AT_CHECK([${COBJ} prog.cbl])
AT_CHECK([java prog])

AT_CLEANUP