Fix add statements and subtract statements #546
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request modifies the
CobolNumericFieldto fix subtract statements against PIC 9 variables. The most important changes include the addition of a method to check for positive or negative zero, an adjustment in the subtraction logic, and the inclusion of new test cases.Enhancements to
CobolNumericFieldclass:displaySubIntmethod to adjust the byte value if it is greater than or equal to0x70. (libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/data/CobolNumericField.java)isPositiveZeroOrNegativeZeromethod to check if the field is either positive or negative zero, and updatedaddIntmethod to use this check. (libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/data/CobolNumericField.java)Additions to test cases:
fix-subtract.atto test various subtraction scenarios in COBOL programs. (tests/misc.src/fix-subtract.at)