'-static' option not working correctly

[demian51]

Hello!

I'm using OpenSSL with static linking in Windows, using Visual Studio 2019. Lately, I updated the library from 1.1.0e to 1.1.1f and the library is not correctly built. When I try to build a library, the script adds /MD option although I appended -static. In 1.1.0e it set /MT option correctly.

I searched and found #11414, but it was not helpful. After some trial and error, I realized that the file Configure has the error. In commit aacae7a(see line 1573) the script was not correctly modified. Originally the option -static made shared disabled, but it turns off static after the commit.

If I add no-shared explicitly, everything works fine. It seems that the script needs a fix.(Or should I make a pull request?)

[levitte]

Originally the option -static made shared disabled, but it turns off static after the commit.

Not quite. The first argument to disable() is the disable type, i.e. what is assigned to $disable{something}, so this line explicitly disables pic and threads:

openssl/Configure

Line 1512 in e78f2a8

disable('static', 'pic', 'threads');

However, because of this line in @disable_cascades, shared should be automatically disabled as well:

openssl/Configure

Line 493 in e78f2a8

"pic" => [ "shared" ],

So you might want to have a closer look at why shared isn't disabled when it should...

[demian51]

Oh I missed that point. Then the code is innocent...
I found that dynamic_engine is also in disabled features list,

dynamic-engine [cascade]

but in configdata.pm the variable dynamic_engine still has "1". I'll try to look into disable_cascades.

[demian51]

I did bisect and identified that the bug had begun after the commit 0072137.

openssl/Configure

Line 1562 in 0072137

$disabled{"pic"} = "forced";

shared, pic, and threads are disabled here. But some processing about the options is done already. So the tasks aren't applied correctly, I think.
For example, dynamic-engine is inserted to the array disabled at line 1562, but the variable dynamic_engine is already set as "1" here.

openssl/Configure

Line 1325 in 0072137

if ($disabled{"dynamic-engine"}) {

I'm not sure because I don't know Perl at all, but it seems that the disabling code should appear earlier. Or is there anything that I missed again...?

[levitte]

The disabling stuff was reworked to use this function:

openssl/Configure

Lines 1064 to 1086 in c61ced5

	sub disable {
	my $disable_type = shift;
	for (@_) {
	$disabled{$_} = $disable_type;
	}
	my @tocheckfor = (@_ ? @_ : keys %disabled);
	while (@tocheckfor) {
	my %new_tocheckfor = ();
	my @cascade_copy = (@disable_cascades);
	while (@cascade_copy) {
	my ($test, $descendents) =
	(shift @cascade_copy, shift @cascade_copy);
	if (ref($test) eq "CODE" ? $test->() : defined($disabled{$test})) {
	foreach (grep { !defined($disabled{$_}) } @$descendents) {
	$new_tocheckfor{$_} = 1; $disabled{$_} = "cascade";
	}
	}
	}
	@tocheckfor = (keys %new_tocheckfor);
	}
	}

The intention is that everytime we disable some feature(s), it runs through @disable_cascade.
As for "... but the variable dynamic_engine is already set as "1" here", I'm not sure I understand the issue. The value "1" is 'true', so it means that this feature is, indeed, disabled.

[t8m]

The version 1.1.1 is not supported anymore. Closing. If this is still an issue with currently supported releases, please open a new issue.