Remove redundant OPENSSL_assert(i <= n) checks in b64_write() #27401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
t8m
reviewed
Apr 16, 2025
t8m
added
branch: master
openssl-machine
removed
the
hold: cla required
Currently, the code asserts that the return value of BIO_write() does not exceed n bytes. However, other calls to BIO_write() do not perform such a check. Since there is no special handling in b64_write() that would require this assertion, it is safe to remove it.
openssl-machine
added
the
hold: cla required
openssl-machine
removed
the
hold: cla required
|
Thank you! Updated. |
t8m
added
approval: review pending
t8m
previously approved these changes
Apr 29, 2025
mattcaswell
approved these changes
Apr 29, 2025
t8m
approved these changes
Apr 29, 2025
t8m
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Apr 30, 2025
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27401)
|
Squashed and merged to the master branch. Thank you for your contribution. |
DDvO
pushed a commit
to siemens/openssl
that referenced
this pull request
Jun 16, 2025
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27401)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27401)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27401)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the code asserts that the return value of BIO_write() does not exceed n bytes. However, other calls to BIO_write() do not perform such a check.
Since there is no special handling in b64_write()
that would require this assertion, it is safe to remove it.
Checklist
P.S. I noticed this assertion while reading the code. Although it has not caused any issues, it led me to check whether there are any cases where BIO_write() might return
i > n.