s390x: Fix HMAC to fail update or final call when already finalized #27781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com>
t8m
added
branch: master
t8m
approved these changes
Jun 6, 2025
|
ping @openssl/committers for second review |
t8m
added
the
severity: regression
paulidale
approved these changes
Jun 11, 2025
paulidale
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
openssl-machine
pushed a commit
that referenced
this pull request
Jun 13, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27781) (cherry picked from commit 339ced7)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 13, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27781)
openssl-machine
pushed a commit
that referenced
this pull request
Jun 13, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #27781) (cherry picked from commit 339ced7)
|
Merged to the master, 3.5 and 3.4 branches. Thank you for your contribution. |
DDvO
pushed a commit
to siemens/openssl
that referenced
this pull request
Jun 16, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27781)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27781)
MichaelA-Fireblocks
pushed a commit
to MichaelA-Fireblocks/openssl
that referenced
this pull request
Jul 15, 2025
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails. Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized. Signed-off-by: Ingo Franzki <ifranzki@linux.ibm.com> Reviewed-by: Paul Dale <ppzgs1@gmail.com> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from openssl#27781)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After commit a5d1ead the test step 'test_hmac_final_update_fail' of 'test_hmac' fails.
Return an error when update or final is used after the context has already been finalized. Flag 'iimp' (intermediate-input-message-part) must be 1 to allow an update or final call. If iimp is 0, then the context has already been finalized.