Fix util/find-doc-nits' check_env_vars #28601
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some files in @except_env_files are located in the build directory, not the source directory. Furthermore, because the files and directories in @except_dirs and @except_env_files may look different than the elements in what find() returns, realpath() must be used to ensure that file name comparison matches when it should.
This displays the list of files with line number for each envvar.
…-files' If that fails, it will fall back to finding the files with Find::file.
levitte
added
branch: master
Member
Author
|
Perhaps this should be propagated to older releases as well? I haven't checked, can somebody help? |
Member
Author
|
Should anyone wonder, all these changes remove a number of false positives that can happen because of the presence of untracked files that are set to be ignored (through |
Member
Author
|
Ping? |
jogme
approved these changes
Oct 15, 2025
Contributor
jogme
left a comment
jogme
left a comment
There was a problem hiding this comment.
Looking good; the output is very useful! Thank you!
Member
Author
|
Ping? @openssl/committers |
nhorman
approved these changes
Oct 27, 2025
beldmit
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
Contributor
|
merged to master and 3.6, thank you! |
openssl-machine
pushed a commit
that referenced
this pull request
Oct 30, 2025
Some files in @except_env_files are located in the build directory, not the source directory. Furthermore, because the files and directories in @except_dirs and @except_env_files may look different than the elements in what find() returns, realpath() must be used to ensure that file name comparison matches when it should. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #28601)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 30, 2025
This displays the list of files with line number for each envvar. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #28601)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 30, 2025
…-files' If that fails, it will fall back to finding the files with Find::file. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #28601)
openssl-machine
pushed a commit
that referenced
this pull request
Oct 30, 2025
Some files in @except_env_files are located in the build directory, not the source directory. Furthermore, because the files and directories in @except_dirs and @except_env_files may look different than the elements in what find() returns, realpath() must be used to ensure that file name comparison matches when it should. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from #28601) (cherry picked from commit 29fa220)
MegaManSec
pushed a commit
to MegaManSec/openssl
that referenced
this pull request
Nov 11, 2025
Some files in @except_env_files are located in the build directory, not the source directory. Furthermore, because the files and directories in @except_dirs and @except_env_files may look different than the elements in what find() returns, realpath() must be used to ensure that file name comparison matches when it should. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#28601)
MegaManSec
pushed a commit
to MegaManSec/openssl
that referenced
this pull request
Nov 11, 2025
This displays the list of files with line number for each envvar. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#28601)
MegaManSec
pushed a commit
to MegaManSec/openssl
that referenced
this pull request
Nov 11, 2025
…-files' If that fails, it will fall back to finding the files with Find::file. Reviewed-by: Neil Horman <nhorman@openssl.org> Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com> (Merged from openssl#28601)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains multiple fixes:
Fix util/find-doc-nits' environment variable check exceptions
Some files in @except_env_files are located in the build directory,
not the source directory.
Furthermore, because the files and directories in @except_dirs and
@except_env_files may look different than the elements in what find()
returns, realpath() must be used to ensure that file name comparison
matches when it should.
Fix util/find-doc-nits' check_env_vars to show where envvars were found
This displays the list of files with line number for each envvar.
Fix util/find-doc-nits' check_env_vars to look for files with 'git ls-files'
If that fails, it will fall back to finding the files with Find::file.