asn1: clear error mark on success in asn1_d2i_read_bio #28882
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcaswell
requested changes
Oct 13, 2025
Collaborator
|
This PR is waiting for the creator to make requested changes but it has not been updated for 30 days. If you have made changes or commented to the reviewer please make sure you re-request a review (see icon in the 'reviewers' section). |
t8m
added
branch: master
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com>
mattcaswell
approved these changes
Nov 13, 2025
mattcaswell
added
the
approval: review pending
esyr
approved these changes
Nov 23, 2025
esyr
added
approval: done
openssl-machine
added
approval: ready to merge
Collaborator
|
This pull request is ready to merge |
t8m
approved these changes
Nov 24, 2025
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
Member
|
Merged to all the active branches. Thank you for your contribution. |
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
openssl-machine
pushed a commit
that referenced
this pull request
Nov 24, 2025
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling. Signed-off-by: Joshua Rogers <MegaManSec@users.noreply.github.com> Reviewed-by: Matt Caswell <matt@openssl.org> Reviewed-by: Eugene Syromiatnikov <esyr@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> (Merged from #28882) (cherry picked from commit 7f015c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Balance ERR_set_mark by calling ERR_clear_last_mark on the success path. Prevents a stale mark from skewing later error handling.