Skip to content

DOC: CRL Certificate Issuer and IDP extensions #29136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

DOC: CRL Certificate Issuer and IDP extensions #29136

wants to merge 1 commit into from

Conversation

@n13l
Copy link
Contributor

@n13l n13l commented Nov 13, 2025 •
edited
Loading

DOC: CRL Certificate Issuer and IDP extensions

Updated CHANGE.md for commit e299082

@t8m t8m added branch: master Applies to master branch approval: review pending This pull request needs review by a committer triaged: documentation The issue/pr deals with documentation (errors) tests: exempted The PR is exempt from requirements for testing labels Nov 13, 2025
@t8m
Copy link
Member

t8m commented Nov 13, 2025

@n13l Could you please amend the commit message to point at the commit hash that added this check?

t8m
t8m requested changes Nov 13, 2025
View reviewed changes
@n13l n13l force-pushed the rfc_5280_crl_cert_issuer_ext_no_idp_ext_doc branch from d4cec1a to a26722f Compare November 13, 2025 10:16
@n13l n13l changed the title DOC: Certificate Issuer when IDP Indirect != TRUE. DOC: CRL Certificate Issuer and IDP extensions Nov 13, 2025
t8m
t8m previously approved these changes Nov 13, 2025
View reviewed changes
@t8m t8m requested review from levitte and mattcaswell November 13, 2025 10:29
@DajanaV DajanaV mentioned this pull request Nov 13, 2025
Open
@t8m t8m requested a review from a team November 19, 2025 10:47
@n13l n13l force-pushed the rfc_5280_crl_cert_issuer_ext_no_idp_ext_doc branch from a26722f to fccd913 Compare November 19, 2025 11:01
t8m
t8m previously approved these changes Nov 19, 2025
View reviewed changes
@t8m t8m requested a review from a team November 19, 2025 13:35
beldmit
beldmit previously approved these changes Nov 19, 2025
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beldmit beldmit added approval: done This pull request has the required number of approvals and removed approval: review pending This pull request needs review by a committer labels Nov 19, 2025
paulidale
paulidale previously approved these changes Nov 19, 2025
View reviewed changes
vdukhovni
vdukhovni previously approved these changes Nov 20, 2025
View reviewed changes
Copy link

@vdukhovni vdukhovni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, in case you agree, feel free to adopt suggested editorial tweaks.

@n13l n13l dismissed stale reviews from vdukhovni, paulidale, beldmit, and t8m via 31b1215 November 20, 2025 04:05
@n13l @vdukhovni
DOC: CRL Certificate Issuer and IDP extensions
cacc6f6 
Updated CHANGE.md for commit e299082

Co-authored-by: Viktor Dukhovni <viktor1ghub@dukhovni.org>
@n13l n13l force-pushed the rfc_5280_crl_cert_issuer_ext_no_idp_ext_doc branch from 31b1215 to cacc6f6 Compare November 20, 2025 04:12
@n13l n13l requested review from t8m and vdukhovni November 20, 2025 04:14
@n13l n13l requested review from beldmit and paulidale November 20, 2025 04:14
beldmit
beldmit approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@beldmit beldmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t8m t8m added approval: done This pull request has the required number of approvals and removed approval: done This pull request has the required number of approvals labels Nov 20, 2025
@openssl-machine openssl-machine added approval: ready to merge The 24 hour grace period has passed, ready to merge and removed approval: done This pull request has the required number of approvals labels Nov 21, 2025
@openssl-machine
Copy link
Collaborator

openssl-machine commented Nov 21, 2025

This pull request is ready to merge

@t8m
Copy link
Member

t8m commented Nov 21, 2025

Merged to the master branch. Thank you.

openssl-machine pushed a commit that referenced this pull request Nov 21, 2025
@n13l @t8m
CHANGES.md: CRL Certificate Issuer and IDP extensions
3f0fb59 
Updated CHANGES.md for commit e299082

Co-authored-by: Viktor Dukhovni <viktor1ghub@dukhovni.org>

Reviewed-by: Dmitry Belyavskiy <beldmit@gmail.com>
Reviewed-by: Viktor Dukhovni <viktor@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from #29136)
@t8m t8m closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vdukhovni vdukhovni vdukhovni approved these changes

@t8m t8m t8m approved these changes

@beldmit beldmit beldmit approved these changes

@levitte levitte Awaiting requested review from levitte

@mattcaswell mattcaswell Awaiting requested review from mattcaswell

@paulidale paulidale Awaiting requested review from paulidale

Assignees

No one assigned

Labels

approval: ready to merge The 24 hour grace period has passed, ready to merge branch: master Applies to master branch tests: exempted The PR is exempt from requirements for testing triaged: documentation The issue/pr deals with documentation (errors)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@n13l @t8m @openssl-machine @vdukhovni @beldmit @paulidale