Company to User Implementation#68
Merged
gulshanvasnani merged 4 commits intoOpenST:developfrom Feb 6, 2019
Merged
Conversation
…to_user # Conflicts: # dist/openst.min.js
Contributor
gulshanvasnani
left a comment
gulshanvasnani
left a comment
There was a problem hiding this comment.
Nice work 👍
Few inline comments.
|
|
||
| const UserWalletFactoryContractName = 'UserWalletFactory'; | ||
|
|
||
| const ProxyFactoryContractName = 'ProxyFactory'; |
Contributor
There was a problem hiding this comment.
Change it to :-
const UserWalletFactoryContractName = 'UserWalletFactory',
ProxyFactoryContractName = 'ProxyFactory',
THMasterCopyContractName = 'TokenHolder';
test/integration/ExecuteRule.js
Outdated
|
|
||
| assert.strictEqual(response.status, true, 'Company wallet creation failed.'); | ||
|
|
||
| // Fetching the gnosisSafe and tokenholder proxy address for the user. |
Contributor
There was a problem hiding this comment.
It verifies only tokenholder proxy address.Please change the comment.
lib/helper/User.js
Outdated
| * @param sessionKeysExpirationHeights Array of expiration heights. | ||
| * @returns {*} | ||
| */ | ||
| getTokenHolderSetupData(owner, sessionKeys, sessionKeysSpendingLimits, sessionKeysExpirationHeights) { |
Contributor
There was a problem hiding this comment.
Suggestion getTokenHolderSetupData => getTokenHolderSetupExecutableData
| } | ||
|
|
||
| /** | ||
| * Private method used for creation and configuration of token holder proxy contract for company |
Contributor
There was a problem hiding this comment.
Full stop at the end.
lib/helper/User.js
Outdated
| _createCompanyWalletRawTx(proxyFactory, owner, sessionKeys, sessionKeysSpendingLimits, sessionKeysExpirationHeights) { | ||
| const oThis = this; | ||
|
|
||
| const thSetupData = oThis.getTokenHolderSetupData( |
Contributor
There was a problem hiding this comment.
Suggestion thSetupData => thSetupExecutableData
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR covers below:
Company to User flow:
_masterCopy: TH Mater Copy address
_data: TH Setup executable data