Skip to content

Conversation

@RoyEJohnson
Copy link
Contributor

@RoyEJohnson RoyEJohnson commented Nov 20, 2025

@RoyEJohnson RoyEJohnson force-pushed the save-school-from-student-signup branch from 685f953 to 4210fbf Compare November 20, 2025 17:40
@RoyEJohnson RoyEJohnson requested a review from mwvolo November 20, 2025 17:40
@mwvolo mwvolo requested a review from Copilot November 20, 2025 19:06
Copilot finished reviewing on behalf of mwvolo November 20, 2025 19:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements functionality to store the self-reported school field during student signup and display it on the user's profile page.

  • Adds a school attribute to the student signup form that maps to the self_reported_school field in the User model
  • Displays the self-reported school on the profile page when the value is present
  • Adds a translation key for the self-reported school label

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
app/handlers/newflow/student_signup/signup_form.rb Added school attribute parameter and mapped it to self_reported_school during user creation
app/views/newflow/base/profile_newflow.html.erb Added conditional display of self-reported school field in the profile view
config/locales/en.yml Added translation key "self_reported_school" for the profile display label

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mwvolo mwvolo merged commit b59f08e into main Nov 20, 2025
12 checks passed
@mwvolo mwvolo deleted the save-school-from-student-signup branch November 20, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants