A few things I noticed while helping debug the Rails 5 PR #259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dantemss
changed the title
reedstrm
approved these changes
Jun 12, 2019
Contributor
reedstrm
left a comment
reedstrm
left a comment
There was a problem hiding this comment.
WFM, logical changes. Would review again!
meeragovindaraju
added this to the
Release 2019-07-03; Code Freeze 2019-06-21 milestone
Brooke-Fail
modified the milestones:
Release 2019-07-01; Code Freeze 2019-06-21,
Release 2019-07-17; Code Freeze 2019-07-05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.byebug_historyto.gitignorehost: localhosttoconfig/database.ymlrake db:drop db:create db:migrate db:seedactually runs and for improved compatibility with future migrations)The host option forces Rails to connect to Postgres using the password provided. If I don't add that, it tries to connect using peer authentication and fails. But you should test locally to make sure it doesn't break your setup. This is only for dev/test, production uses its own separate database.yml.