return a 404 if a news slug is not found #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1107 +/- ##
==========================================
+ Coverage 82.52% 82.55% +0.02%
==========================================
Files 369 369
Lines 6388 6396 +8
==========================================
+ Hits 5272 5280 +8
Misses 1116 1116 |
mwvolo
commented
Dec 7, 2020
|
|
||
| def bad_slug_returns_404(self): | ||
| response = self.client.get('/apps/cms/api/news/bad-slug/', format='json') | ||
| self.assertEqual(response.status_code, 404) |
There was a problem hiding this comment.
codecov has officially lost its mind if it's complaining that I am not testing the tests...
There was a problem hiding this comment.
Does it mean that test is never run?
There was a problem hiding this comment.
@RoyEJohnson, the Travis whisperer™️. That's exactly what's happening... I'll investigate.
RoyEJohnson
approved these changes
Dec 9, 2020
|
|
||
| def bad_slug_returns_404(self): | ||
| response = self.client.get('/apps/cms/api/news/bad-slug/', format='json') | ||
| self.assertEqual(response.status_code, 404) |
There was a problem hiding this comment.
Does it mean that test is never run?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of errors in Sentry where bots... or something... are trying to find news articles that do not exist. This appropriately returns a 404, instead of 500.
Example Sentry issue: https://sentry.cnx.org/openstax/cms/issues/303262/