Modified timeout and added certifi to eliminate SSL errors #1115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1115 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 369 369
Lines 6408 6408
=======================================
Hits 5294 5294
Misses 1114 1114 |
edwoodward
force-pushed
the
fix-redirect-report
branch
from
ef91401 to
4e1164d
Compare
mwvolo
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timeout now has 10 seconds for connection and 10 seconds for data load. This solved all of the 429 errors from Youtube. Using certifi to verify certificates. Certifi uses Mozilla's pem file which lists trusted CAs. Since there are still some odd errors from the URL we redirect to being redirected as well, I added the exception to the redirect email sent to the content team. This might or might not be helpful. I left the dev email so I can compare what happens in Feb. when the report runs in production.