Skip to content

Adding TypeError handling to email #1209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

Adding TypeError handling to email #1209

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions errata/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -372,13 +372,16 @@ def send_status_update_email(sender, instance, created, **kwargs):
send_email = True

if not override_to:
if instance.submitted_by_account_id:
user = get_user_info(instance.submitted_by_account_id)
to = user['email']
elif instance.submitter_email_address:
to = instance.submitter_email_address
elif instance.submitted_by:
to = instance.submitted_by.email
try:
if instance.submitted_by_account_id:
user = get_user_info(instance.submitted_by_account_id)
to = user['email']
elif instance.submitter_email_address:
to = instance.submitter_email_address
elif instance.submitted_by:
to = instance.submitted_by.email
except TypeError:
send_email = False
else:
send_email = False

Expand Down