Skip to content

Filter successful /ping requests from Django logs #1278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2022
Merged

Filter successful /ping requests from Django logs #1278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f4fc6e
Filter /ping requests from Django logs
Dantemss Apr 28, 2022
0496871
Merge branch 'main' into filter_ping
Dantemss May 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions healthcheck/filter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
from logging import Filter

class HealthCheckFilter(Filter):
def filter(self, record):
# Should return True for all requests except successful healthcheck requests
return record.status_code != 204 or not (
record.args[0].startswith('GET /ping ') or
record.args[0].startswith('GET /ping/')
)
12 changes: 10 additions & 2 deletions openstax/settings/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,11 @@
logging.config.dictConfig({
'version': 1,
'disable_existing_loggers': False,
'filters': {
'healthcheck_filter': {
'()': 'healthcheck.filter.HealthCheckFilter'
},
},
'formatters': {
'default': {
# exact format is not important, this is the minimum information
Expand All @@ -300,7 +305,7 @@
'django.server': DEFAULT_LOGGING['formatters']['django.server'],
},
'handlers': {
#disable logs set with null handler
# disable logs set with null handler
'null': {
'class': 'logging.NullHandler',
},
Expand All @@ -309,7 +314,10 @@
'class': 'logging.StreamHandler',
'formatter': 'default',
},
'django.server': DEFAULT_LOGGING['handlers']['django.server'],
'django.server': {
**DEFAULT_LOGGING['handlers']['django.server'],
'filters': ['healthcheck_filter']
},
},
'loggers': {
# default for all undefined Python modules
Expand Down