Added Content License drop down to select license of book #1285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwoodward
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1285 +/- ##
==========================================
+ Coverage 86.57% 86.62% +0.04%
==========================================
Files 490 495 +5
Lines 7777 7819 +42
==========================================
+ Hits 6733 6773 +40
- Misses 1044 1046 +2 |
edwoodward
force-pushed
the
cc-licenses
branch
2 times, most recently
from
d940e00 to
13c84d2
Compare
mwvolo
reviewed
May 11, 2022
| license_name = models.CharField( | ||
| max_length=255, blank=True, null=True, editable=False, help_text="Name of the license.") | ||
| max_length=255, blank=True, null=True, choices=licenses,default=CC_BY_LICENSE_NAME, help_text="Name of the license.") | ||
| license_version = models.CharField( |
There was a problem hiding this comment.
do the other license fields not need similar choices?
mwvolo
reviewed
May 11, 2022
| if self.support_statement: | ||
| Book.objects.filter(locale=self.locale).update(support_statement=self.support_statement) | ||
|
|
||
| # populate license |
There was a problem hiding this comment.
ah, I see what you are doing - might want to set the other license fields to uneditable then editable=False
mwvolo
reviewed
May 11, 2022
| from wagtail.tests.utils import WagtailPageTests | ||
| from wagtail.core.models import Page | ||
|
|
||
| import snippets.models |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.