Skip to content

Conversation

Dantemss
Copy link
Member

Since the CMS owns any paths not specified in CloudFront, it's easier to just serve it from here rather than creating a new origin just to serve /dist/assets/favicon.ico as /favicon.ico

@Dantemss Dantemss requested a review from mwvolo May 11, 2022 16:20
@Dantemss Dantemss self-assigned this May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #1289 (9dbe9fe) into main (1686534) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1289   +/-   ##
=======================================
  Coverage   86.57%   86.57%           
=======================================
  Files         490      490           
  Lines        7777     7777           
=======================================
  Hits         6733     6733           
  Misses       1044     1044           

@Dantemss Dantemss merged commit f061362 into main May 11, 2022
@Dantemss Dantemss deleted the favicon branch May 11, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants