Skip to content

add locale filter to snippet roles #1610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2025
Merged

add locale filter to snippet roles #1610

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions snippets/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,18 @@
queryset = Role.objects.all()
serializer_class = RoleSerializer

def get_queryset(self):
queryset = Role.objects.all().order_by('display_name')
name = self.request.query_params.get('name', None)
locale = self.request.query_params.get('locale', None)
if name is not None:
queryset = queryset.filter(display_name=name)

Check warning on line 27 in snippets/views.py

View check run for this annotation

Codecov / codecov/patch

snippets/views.py#L27 

Added line #L27 was not covered by tests
if locale is not None:
queryset = queryset.filter(locale=convert_locale(locale))

Check warning on line 29 in snippets/views.py

View check run for this annotation

Codecov / codecov/patch

snippets/views.py#L29 

Added line #L29 was not covered by tests
else:
queryset = queryset.filter(locale=ENGLISH_LOCALE_ID)
return queryset


class SubjectList(viewsets.ReadOnlyModelViewSet):
serializer_class = SubjectSerializer
Expand Down
Loading