Make some functions return void instead of int #1021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return values are not used. This continues the refactor started in 1e76aff.
The result is never used.
lonvia
reviewed
Dec 8, 2019
src/output-pgsql.cpp
Outdated
| auto const &rel = rels_buffer.get<osmium::Relation>(0); | ||
| return pgsql_process_relation(rel); | ||
| pgsql_process_relation(rel); | ||
| return; |
Collaborator
Author
There was a problem hiding this comment.
The new way makes clear that pgsql_process_relation doesn't return anything. If we ever change the function this is in to return something again, this new code will break regardless of whether pgsql_process_relation returns something or not, helping us to detect that there is a place here that needs looking at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second batch of changes after #1020 switching the return type of some functions from int to void where the result is never used.