Move file reading functionality from parse_osmium_t to osmdata_t #1205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This leaves only the functionality as Osmium handler in parse_osmium_t. This commit also leverages the ability of osmium::io::Reader to read from either a file or a buffer when it is called with an osmium::io::File parameter. By creating the osmium::io::File outside the process_file() function, we don't need the special class test_parse_t any more.
joto
force-pushed
the
move-file-read-into-osmdata
branch
from
58f6271 to
19112f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This leaves only the functionality as Osmium handler in parse_osmium_t.
This commit also leverages the ability of osmium::io::Reader to read
from either a file or a buffer when it is called with an
osmium::io::File parameter. By creating the osmium::io::File outside the
process_file() function, we don't need the special class test_parse_t
any more.