Refactor expire code #1648
Merged
Refactor expire code #1648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lonvia
reviewed
Mar 4, 2022
| from_point_list(geom.get<geom::polygon_t>().outer()); | ||
| } else if (geom.is_multipolygon()) { | ||
| for (auto const &polygon : geom.get<geom::multipolygon_t>()) { | ||
| from_point_list(polygon.outer()); |
Collaborator
There was a problem hiding this comment.
The original code expires all rings here.
Collaborator
Author
There was a problem hiding this comment.
Fixed and force-pushed.
This disentangles the WKB code from the expire code. There are further refactorings to be done, but they will come in later commits to keep things separate.
joto
force-pushed
the
geometry-refactor-expire
branch
from
2e2cff0 to
c27ca82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disentangles the WKB code from the expire code. There are further refactorings to be done, but they will come in later commits to keep things separate.