Use min/max in expire and remove superfluous check #1808
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also uses std::clamp()
The code in expire_from_result() will also do nothing if called with empty results.
lonvia
reviewed
Nov 3, 2022
| auto const tmp_min = coords_to_tile({box.min_x(), box.max_y()}); | ||
| int min_tile_x = tmp_min.x() - tile_expiry_leeway; | ||
| int min_tile_y = tmp_min.y() - tile_expiry_leeway; | ||
| auto const tmp_min = coords_to_tile(box.min()); |
Collaborator
There was a problem hiding this comment.
This code is not the same. box.min() returns min_y while the old code has max_y. Is this a problem?
Collaborator
Author
There was a problem hiding this comment.
Yes it is! Now that we have tests (from another recently added PR) we can immediately see that they fail!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.