Consolidate database capability checks #1843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were several places (pgsql.hpp, pgsql-capabilities.hpp, db-check.hpp) that had code to check various capabilities, version numbers etc. of the database we are connected to. This is now consolidated in pgsql-capabilities.hpp. It needs to be initialized once at program start by calling init_database_capabilities() with a database connection object. Checking version numbers or capabilities is then much easier, because no active database connection is needed any more. This also adds code to get the list of supported index methods from the database which we will need shortly. (Only works with PostgreSQL >9.5.)
joto
force-pushed
the
refactor-db-capabilities
branch
from
6bf9c3c to
2ed7e91
Compare
lonvia
reviewed
Dec 2, 2022
| - uses: actions/checkout@v3 | ||
| - uses: ./.github/actions/ubuntu-prerequisites | ||
| - uses: ./.github/actions/build-and-test | ||
|
|
Collaborator
There was a problem hiding this comment.
Are you sure you want to loose the test with gcc7?
Collaborator
Author
There was a problem hiding this comment.
No. I have put it back in.
PostgreSQL 9.5 has been marked as unsupported for a while, both by the PostgreSQL itself as by us. This removes the build on Github action which is failing now.
joto
force-pushed
the
refactor-db-capabilities
branch
from
2ed7e91 to
cdc523d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were several places (pgsql.hpp, pgsql-capabilities.hpp, db-check.hpp) that had code to check various capabilities, version numbers etc. of the database we are connected to. This is now consolidated in pgsql-capabilities.hpp. It needs to be initialized once at program start by calling init_database_capabilities() with a database connection object. Checking version numbers or capabilities is then much easier, because no active database connection is needed any more.
This also adds code to get the list of supported index methods from the database which we will need shortly.