Skip to content

Conversation

@pnorman
Copy link
Collaborator

@pnorman pnorman commented Jul 4, 2015

The C transforms used to turn the name tag into a route_name tag on
route relations, for reasons that are not entirely clear. This change
doesn't remove route_name, but does also populate the name column,
eliminating a source of confusion to users.

Fixes #315

The C transforms used to turn the name tag into a route_name tag on
route relations, for reasons that are not entirely clear. This change
doesn't remove route_name, but does also populate the name column,
eliminating a source of confusion to users.

Fixes osm2pgsql-dev#315
@woodpeck
Copy link
Contributor

woodpeck commented Jul 4, 2015

The C transforms used to turn the name tag into a route_name tag on
route relations, for reasons that are not entirely clear.

The reason for this was that in times past, the openstreetmap.org Mapnik rendering would render the names of anything that had the name column set, so populating the name column on route relations would have forced them all onto the map. This has been fixed years ago though.

@pnorman
Copy link
Collaborator Author

pnorman commented Jul 4, 2015

The reason for this was that in times past, the openstreetmap.org Mapnik rendering would render the names of anything that had the name column set

Ah, of course - the fallbacks. That explains why.

I'm still in favour of this change. fallbacks that generically render all name tags have been broken for years. If anyone is rendering all name tags with recent data and a recent osm2pgsql, this will hardly increase how broken their style.

pnorman added a commit that referenced this pull request Jul 5, 2015
Populate name column for route relations
@pnorman pnorman merged commit 5568afb into osm2pgsql-dev:master Jul 5, 2015
@pnorman pnorman deleted the route_name branch July 5, 2015 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants