explicit type conversions to reduce MSVC warnings #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
There was a problem hiding this comment.
We are not going to have 2Gb SQL, I hope. Was warning about size_t -> int conversion.
Collaborator
There was a problem hiding this comment.
the length goes to PQputCopyData(PGconn *conn, const char *buffer, int nbytes); so we're fine
pnorman
added a commit
that referenced
this pull request
Oct 29, 2015
explicit type conversions to reduce MSVC warnings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the cosmetic fix that reduces the number of MSVC warnings
#470
(all warnings in hpps)