Appveyor artifacts fix #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 27, 2018 16:04
We used platform env variable to differ between x86 and x64 arch. But calling the VisualStudio's vcvarsall script for x64 will redefine the platform variable as X64. As the result, the x64 artifact will be named osm2pgsql_Release_X64.zip, instead of osm2pgsql_Release_x64.zip. So to avoid this issue, changed platform env variable to arch.
Collaborator
|
Thanks again for providing a fix so quickly. The platform issue explains a lot of the odd behaviour that I saw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the issue that mentioned #820 (comment)
Now the artifacts can be accessed using below URLs:
Also the "platform" environment variable renamed to "arch" because the collision with VisualStduio's vcvarsall script for x64 platform. By calling vcvarsall script the "platform" environment variable will be changed to "X64" instead of "x64". Because of the issue, the build artifact for x64 was named "osm2pgsql_Release_X64.zip" instead of "osm2pgsql_Release_x64.zip". So changed "platform" to "arch" environment variable.