fix: extension list do not show (#127)

Author: bytemain

packages/startup/src/startup/startup.module.ts

@@ -129,10 +129,11 @@ class StartupContribution implements MainLayoutContribution {
 
   async onDidRender(): Promise<void> {
     await this.layoutService.viewReady.promise;
-    const leftTabBarHandler = this.layoutService.getTabbarService('left');
-    leftTabBarHandler.updateCurrentContainerId('');
-
-    console.log("hide left tabbar by default")
+    if (process.env.HIDE_LEFT_TABBAR) {
+      const leftTabBarHandler = this.layoutService.getTabbarService('left');
+      leftTabBarHandler.updateCurrentContainerId('');
+      console.log("hide left tabbar by default")
+    }
   }
 }
 

packages/sumi-core/src/client/extension-manager/extension-manager.contribution.ts

@@ -1,7 +1,7 @@
 import { Autowired } from '@opensumi/di';
 import { getIcon } from '@opensumi/ide-core-browser';
 import { ComponentContribution, ComponentRegistry } from '@opensumi/ide-core-browser/lib/layout';
-import { Domain, localize } from '@opensumi/ide-core-common';
+import { DisposableStore, Domain, localize } from '@opensumi/ide-core-common';
 import {
   BrowserEditorContribution,
   EditorComponentRegistry,
@@ -20,6 +20,8 @@ import { ExtensionResourceProvider } from './extension-resource-provider';
 export class ExtensionManagerContribution
   implements ComponentContribution, MainLayoutContribution, BrowserEditorContribution
 {
+  protected _disposables = new DisposableStore();
+
   @Autowired()
   private readonly resourceProvider: ExtensionResourceProvider;
 
@@ -30,25 +32,27 @@ export class ExtensionManagerContribution
   private readonly extensionManagerService: ExtensionManagerService;
 
   registerResource(resourceService: ResourceService) {
-    resourceService.registerResourceProvider(this.resourceProvider);
+    this._disposables.add(resourceService.registerResourceProvider(this.resourceProvider));
   }
 
   registerEditorComponent(editorComponentRegistry: EditorComponentRegistry) {
     const EXTENSIONS_DETAIL_COMPONENT_ID = `${EXTENSION_SCHEME}_detail`;
-    editorComponentRegistry.registerEditorComponent({
+    this._disposables.add(editorComponentRegistry.registerEditorComponent({
       component: ExtensionDetailView,
       uid: EXTENSIONS_DETAIL_COMPONENT_ID,
       scheme: EXTENSION_SCHEME,
-    });
+    }));
 
-    editorComponentRegistry.registerEditorComponentResolver(EXTENSION_SCHEME, (_, __, resolve) => {
-      resolve([
-        {
-          type: EditorOpenType.component,
-          componentId: EXTENSIONS_DETAIL_COMPONENT_ID,
-        },
-      ]);
-    });
+    this._disposables.add(
+      editorComponentRegistry.registerEditorComponentResolver(EXTENSION_SCHEME, (_, __, resolve) => {
+        resolve([
+          {
+            type: EditorOpenType.component,
+            componentId: EXTENSIONS_DETAIL_COMPONENT_ID,
+          },
+        ]);
+      }),
+    );
   }
 
   registerComponent(registry: ComponentRegistry): void {
@@ -62,13 +66,22 @@ export class ExtensionManagerContribution
     });
   }
 
-  onDidRender() {
+  async onDidRender() {
+    await this.mainLayoutService.viewReady.promise;
     const handler = this.mainLayoutService.getTabbarHandler(enableExtensionsContainerId);
     if (handler) {
       // 在激活的时候获取数据
-      handler.onActivate(() => {
+      if (handler.isActivated()) {
         this.extensionManagerService.init();
-      });
+      } else {
+        this._disposables.add(handler.onActivate(() => {
+          this.extensionManagerService.init();
+        }));
+      }
     }
   }
+
+  dispose() {
+    this._disposables.dispose();
+  }
 }