Skip to content

Commit 219f2c0

Browse files
author
winjo
committed
feat: rename module git to code-service
1 parent 0141fcf commit 219f2c0

29 files changed

Lines changed: 211 additions & 207 deletions

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
"init": "npm run clean && npm run build && npm run ext",
1616
"start": "npm run dev",
1717
"ext": "alex ext",
18-
"sdk": "INTEGRATION=sdk npm run dev",
1918
"inspect": "INTEGRATION=inspect npm run dev",
2019
"build": "node scripts/build",
20+
"bundle": "node scripts/bundle",
2121
"create": "node scripts/create",
2222
"format": "prettier --write --parser typescript \"packages/**/*.ts?(x)\"",
2323
"dev": "webpack serve --config packages/toolkit/webpack/config.dev.js",

packages/alex/package.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -67,10 +67,8 @@
6767
"@alipay/alex-cli": "0.2.9",
6868
"@alipay/alex-core": "0.2.9",
6969
"@alipay/alex-shared": "0.2.9",
70-
"@alipay/alex-git": "0.2.9",
71-
"@alipay/alex-i18n": "0.2.9",
72-
"iconv-lite-umd": "^0.6.8",
73-
"jschardet": "^2.2.1"
70+
"@alipay/alex-code-service": "0.2.9",
71+
"@alipay/alex-i18n": "0.2.9"
7472
},
7573
"tnpm": {
7674
"mode": "yarn",
@@ -81,7 +79,6 @@
8179
"@types/react-dom": "^16.9.9",
8280
"antd": "^3.20.3",
8381
"react": "^16.14.0",
84-
"react-dom": "^16.14.0",
85-
"vscode-languageserver-types": "~3.14"
82+
"react-dom": "^16.14.0"
8683
}
8784
}

packages/alex/src/api/createApp.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ export function createApp({ appConfig, runtimeConfig }: IConfig): IAppInstance {
103103
(app.injector.get(IThemeService) as IThemeService).onThemeChange((e) => {
104104
themeStorage.set(e.type);
105105
});
106-
// IDE 销毁时,组件会触发 handleTreeBlur,但是 FileContextKey 实例会获取,此时在 dispose 阶段,injector.get(FileContextKey) 会抛出错误
106+
// IDE 销毁时,组件会触发 handleTreeBlur,但是 FileContextKey 实例尚未初始化,此时在 dispose 阶段,injector.get(FileContextKey) 会抛出错误
107107
app.injector.get(FileTreeModelService).handleTreeBlur();
108108
};
109109

packages/alex/src/api/renderApp.tsx

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
1-
import React, { useState, useEffect } from 'react';
1+
import React, { useState, useEffect, useRef } from 'react';
22
import ReactDOM from 'react-dom';
33
import { IReporterService, localize, getDebugLogger } from '@ali/ide-core-common';
4+
import { REPORT_NAME } from '@alipay/alex-core';
45
import { createApp } from './createApp';
56
import { Root } from '../core/Root';
67
import { RootProps, LandingProps } from '../core/types';
@@ -40,9 +41,9 @@ export const renderApp = (domElement: HTMLElement, props: IRenderProps) => {
4041
domElement
4142
);
4243

43-
(app.injector.get(IReporterService) as IReporterService).point('alex:error', 'startApp', {
44-
error: err,
45-
});
44+
(app.injector.get(
45+
IReporterService
46+
) as IReporterService).point(REPORT_NAME.ALEX_APP_START_ERROR, err?.message, { error: err });
4647
getDebugLogger().error(err);
4748
setTimeout(() => {
4849
throw err;
@@ -57,7 +58,7 @@ export const renderApp = (domElement: HTMLElement, props: IRenderProps) => {
5758
export const AppRenderer: React.FC<IRenderProps> = ({ onLoad, Landing, ...opts }) => {
5859
const app = useConstant(() => createApp(opts));
5960
const themeType = useConstant(() => themeStorage.get());
60-
const [appElement, setAppElement] = useState<React.ReactElement | null>(null);
61+
const appElementRef = useRef<React.ReactElement | null>(null);
6162

6263
const [state, setState] = useState<{
6364
status: RootProps['status'];
@@ -67,17 +68,19 @@ export const AppRenderer: React.FC<IRenderProps> = ({ onLoad, Landing, ...opts }
6768
useEffect(() => {
6869
app
6970
.start((appElement) => {
70-
setAppElement(appElement);
71+
appElementRef.current = appElement;
72+
setState({ status: 'success' });
7173
return Promise.resolve();
7274
})
7375
.then(() => {
74-
setState({ status: 'success' });
7576
onLoad?.(app);
7677
})
7778
.catch((err: Error) => {
7879
setState({ error: err?.message || localize('error.unknown'), status: 'error' });
7980

80-
(app.injector.get(IReporterService) as IReporterService).point('alex:error', 'startApp', {
81+
(app.injector.get(
82+
IReporterService
83+
) as IReporterService).point(REPORT_NAME.ALEX_APP_START_ERROR, err?.message, {
8184
error: err,
8285
});
8386
getDebugLogger().error(err);
@@ -93,7 +96,7 @@ export const AppRenderer: React.FC<IRenderProps> = ({ onLoad, Landing, ...opts }
9396

9497
return (
9598
<Root {...state} theme={themeType} Landing={Landing}>
96-
{appElement}
99+
{appElementRef.current}
97100
</Root>
98101
);
99102
};

packages/alex/src/core/style.module.less

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ alex-root {
77

88
.landing {
99
position: absolute;
10+
z-index: 10;
1011
left: 0;
1112
right: 0;
1213
top: 0;

packages/alex/src/integration/startup/index.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import React from 'react';
22
import ReactDOM from 'react-dom';
3-
import { GitFileSchemeModule } from '@alipay/alex-git';
3+
import { GitFileSchemeModule } from '@alipay/alex-code-service';
44
import { IAppInstance, AppRenderer } from '../..';
55
import * as Alex from '../..';
66
import { StartupModule } from './startup.module';
@@ -36,7 +36,7 @@ ReactDOM.render(
3636
workspaceDir: project,
3737
}}
3838
runtimeConfig={{
39-
git: {
39+
codeService: {
4040
platform: 'antcode',
4141
baseURL: '/code-service',
4242
project,

packages/code-service/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
# code-service
2+
3+
这个模块封装了 antcode 的请求,按理应该在写在集成侧,但又考虑到如果 antcode 项目中也可能使用,可能会重复
4+
5+
先作为单独模块使用,再看优化方法

packages/git/__tests__/index.test.ts renamed to packages/code-service/__tests__/index.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
describe('git', () => {
1+
describe('code-service', () => {
22
it('example', () => {
33
expect(1 + 1).toBe(2);
44
});
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "@alipay/alex-git",
2+
"name": "@alipay/alex-code-service",
33
"version": "0.2.9",
4-
"description": "@alipay/alex-git",
4+
"description": "@alipay/alex-code-service",
55
"main": "lib/index.js",
66
"typings": "lib/index.d.ts",
77
"files": [

packages/git/src/git-api.service.ts renamed to packages/code-service/src/code-api.service.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,12 @@
11
import { Injectable, Autowired } from '@ali/common-di';
2-
import { GitModelService } from './git-model.service';
2+
import { CodeModelService } from './code-model.service';
33
import { request, API } from './request';
4-
import { IGitAPIService } from './types';
4+
import { ICodeAPIService } from './types';
55

66
@Injectable()
7-
export class GitAPIService implements IGitAPIService {
7+
export class CodeAPIService implements ICodeAPIService {
88
@Autowired()
9-
gitModel: GitModelService;
9+
gitModel: CodeModelService;
1010

1111
getProjectInfo() {
1212
return request<API.ResponseGetProjectById>(

0 commit comments

Comments
 (0)