fix: remove useless props

Author: taian.lta

packages/acr/src/modules/antcode-service/base.ts

@@ -102,61 +102,11 @@ export interface IAntcodeCRProps {
   // components
   PRMoreActionLinks: React.ComponentType<any>;
 
-  // jsx elements
-
-  // others
-  renderStart: number;
-
   getFileReadStatus(filePath: string): boolean;
 
   fileReadMarkChange$: {
     useSubscription: (callback: (filePath: string) => void) => void;
   };
-
-  // lsif service
-  lsifService: {
-    lsifExists(projectId: number, sha: string): Promise<boolean | null>;
-    lsifHover(
-      projectId: number,
-      data: LSIFBaseParams
-    ): Promise<{
-      contents: {
-        kind: string;
-        value: string;
-      };
-      range: LSIFRange;
-    }>;
-    lsifDefinitions(
-      projectId: number,
-      data: LSIFBaseParams
-    ): Promise<{ uri: string; range: LSIFRange }[]>;
-    lsifReferences(
-      projectId: number,
-      data: LSIFBaseParams & {
-        pageNum: number;
-        pageSize: number;
-      }
-    ): Promise<{
-      fileCount: number;
-      refCount: number;
-      refList: {
-        uri: string;
-        referenceChunks: {
-          content: string;
-          position: LSIFPosition;
-        }[];
-      }[];
-    }>;
-    lsifReferencesV2(
-      projectId: number,
-      data: LSIFBaseParams
-    ): Promise<
-      {
-        range: Range;
-        uri: string;
-      }[]
-    >;
-  };
 }
 
 export interface LsifLocation {
@@ -188,13 +138,13 @@ export interface IComment extends Required<INoteData> {
   noteId: number;
 }
 
-export const IAntcodeService = Symbol('IAntcodeService');
-
 export type TCommitFiles = (
   fileList: Array<Pick<FileAction, 'content' | 'filePath'>>,
   meta: Omit<FileActionHeader, 'authorEmail' | 'authorName'>
 ) => ReturnType<IAntcodeCRProps['bulkChangeFiles']>;
 
+export const IAntcodeService = Symbol('IAntcodeService');
+
 export interface IAntcodeService {
   /**
    * 用来划定 workspaceDir 的位置的唯一 key
@@ -273,13 +223,11 @@ export interface IAntcodeService {
   PRMoreActionLinks: IAntcodeCRProps['PRMoreActionLinks'];
 
   // others
-  renderStart: IAntcodeCRProps['renderStart'];
+  renderStart: number;
 
   didViewChangeEmitter: Emitter<string>;
   onDidViewChange: Event<string>;
 
-  lsifService: IAntcodeCRProps['lsifService'];
-
   updateConfig(config: Partial<IAntcodeCRProps>): void;
   fireEncodingChange(v: AntcodeEncodingType): void;
 

packages/acr/src/modules/antcode-service/index.ts

@@ -282,8 +282,6 @@ export class AntcodeService implements IAntcodeService {
     return this.config.getFileContent(path, sha, 2500000, charsetName);
   };
 
-  public lsifService: IAntcodeCRProps['lsifService'];
-
   private _isFullscreen: boolean;
   get isFullscreen(): boolean {
     return this._isFullscreen;
@@ -304,7 +302,12 @@ export class AntcodeService implements IAntcodeService {
     };
   }
 
-  constructor(@Optional() private config: IAntcodeCRProps) {
+  constructor(
+    @Optional()
+    private config: IAntcodeCRProps & {
+      renderStart: number;
+    }
+  ) {
     this.addLineNum = config.addLineNum;
     this.deleteLineNum = config.deleteLineNum;
     this.leftRef = config.prevSha;
@@ -341,8 +344,6 @@ export class AntcodeService implements IAntcodeService {
 
     this.renderStart = config.renderStart;
 
-    this.lsifService = config.lsifService;
-
     this.isFullscreen = config.isFullscreen;
   }
 

packages/integrations/src/antcode-cr/mock-props/index.tsx

@@ -75,12 +75,4 @@ export const getProps = (projectId: number): Partial<IAntcodeCRProps> => ({
       </div>
     </>
   ),
-  renderStart: performance.now(),
-  lsifService: {
-    lsifExists,
-    lsifHover,
-    lsifDefinitions,
-    lsifReferencesV2,
-    lsifReferences: () => Promise.resolve([] as any),
-  },
 });