Skip to content

Commit 6d2dd5b

Browse files
author
guqiankun.gqk
committed
chore: 修复部分问题
1 parent 9d440f2 commit 6d2dd5b

4 files changed

Lines changed: 8 additions & 33 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@
150150
{
151151
"publisher": "cloud-ide-ext",
152152
"name": "antcode-scaning",
153-
"version": "0.0.3"
153+
"version": "0.0.5"
154154
}
155155
]
156156
}

packages/acr/src/modules/antcode-service/index.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ export class AntcodeService implements IAntcodeService {
310310
@Optional()
311311
private config: IAntcodeCRProps & {
312312
renderStart: number;
313-
noteIdToReplyIdSet: Map<number | string, Set<number | string>>;
314313
}
315314
) {
316315
this.addLineNum = config.addLineNum;

packages/acr/src/normalize.less

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ html {
1515

1616
::-webkit-scrollbar {
1717
background: transparent;
18-
height: 10px;
19-
width: 10px;
18+
height: inherit;
19+
width: inherit;
2020
}
2121

2222
::-webkit-scrollbar:hover {

packages/integrations/src/antcode-cr/index.tsx

Lines changed: 5 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import React from 'react';
2-
import { useCallback } from 'react';
2+
import { useEffect } from 'react';
33
import ReactDOM from 'react-dom';
44
import { Button, Switch } from 'antd';
55
import 'antd/dist/antd.css';
@@ -49,7 +49,7 @@ const App = () => {
4949
useAcr();
5050
const fileReadMarkChange$ = useFileReadMarkChange$(diffsPack?.diffs ?? [], readMarks);
5151

52-
useCallback(() => {
52+
useEffect(() => {
5353
// map 需要转译
5454
CodeScaningPlugin.commands?.executeCommand(
5555
'antcode-cr.plugin.update.comments',
@@ -58,20 +58,14 @@ const App = () => {
5858

5959
let noteIdToReplyIdSet: [number, number[]][] = [];
6060
for (let [key, value] of commentPack.noteIdToReplyIdSet) {
61-
let setArr: number[] = [];
62-
if (value.size) {
63-
for (let val of value) {
64-
setArr.push(val);
65-
}
66-
}
67-
noteIdToReplyIdSet.push([key, setArr]);
61+
noteIdToReplyIdSet.push([key, [...value]]);
6862
}
6963
CodeScaningPlugin.commands?.executeCommand(
7064
'antcode-cr.plugin.update.replaySet',
7165
noteIdToReplyIdSet
7266
);
7367
}, [commentPack.updateFlag]);
74-
useCallback(() => {
68+
useEffect(() => {
7569
CodeScaningPlugin.commands?.executeCommand(
7670
'antcode-cr.plugin.update.annotations',
7771
annotationPacks
@@ -191,24 +185,6 @@ const App = () => {
191185
id: 400003,
192186
isAward: false,
193187
labels: [],
194-
latestStDiff: {
195-
aMode: '100644',
196-
addLineNum: 265,
197-
bMode: '100644',
198-
binaryFile: false,
199-
charsetName: 'UTF-8',
200-
commitSha: 'ab32441adfd6c3c381457717a42f19a7fdd6d59b',
201-
compareDiffId: 31918,
202-
delLineNum: 265,
203-
deletedFile: false,
204-
diff: '@@ -327,62 +327,62 @@ export const getForgot = (req: Request, res: Response) => {\n * Create a random token, then the send user an email with a reset link.\n */\n export const postForgot = async (req: Request, res: Response, next: NextFunction) => {\n- await check("email", "Please enter a valid email address.").isEmail().run(req);\n- // eslint-disable-next-line @typescript-eslint/camelcase\n- await sanitize("email").normalizeEmail({ gmail_remove_dots: false }).run(req);\n-\n- const errors = validationResult(req);\n-\n- if (!errors.isEmpty()) {\n- req.flash("errors", errors.array());\n- return res.redirect("/forgot");\n- }\n-\n- async.waterfall([\n- function createRandomToken(done: Function) {\n- crypto.randomBytes(16, (err, buf) => {\n- const token = buf.toString("hex");\n- done(err, token);\n- });\n- },\n- function setRandomToken(token: AuthToken, done: Function) {\n- User.findOne({ email: req.body.email }, (err, user: any) => {\n- if (err) { return done(err); }\n- if (!user) {\n- req.flash("errors", { msg: "Account with that email address does not exist." });\n- return res.redirect("/forgot");\n- }\n- user.passwordResetToken = token;\n- user.passwordResetExpires = Date.now() + 3600000; // 1 hour\n- user.save((err: WriteError) => {\n- done(err, token, user);\n- });\n- });\n- },\n- function sendForgotPasswordEmail(token: AuthToken, user: UserDocument, done: Function) {\n- const transporter = nodemailer.createTransport({\n- service: "SendGrid",\n- auth: {\n- user: process.env.SENDGRID_USER,\n- pass: process.env.SENDGRID_PASSWORD\n- }\n- });\n- const mailOptions = {\n- to: user.email,\n- from: "hackathon@starter.com",\n- subject: "Reset your password on Hackathon Starter",\n- text: `You are receiving this email because you (or someone else) have requested the reset of the password for your account.\\n\\n\n+ await check("email", "Please enter a valid email address.").isEmail().run(req);\n+ // eslint-disable-next-line @typescript-eslint/camelcase\n+ await sanitize("email").normalizeEmail({ gmail_remove_dots: false }).run(req);\n+\n+ const errors = validationResult(req);\n+\n+ if (!errors.isEmpty()) {\n+ req.flash("errors", errors.array());\n+ return res.redirect("/forgot");\n+ }\n+\n+ async.waterfall([\n+ function createRandomToken(done: Function) {\n+ crypto.randomBytes(16, (err, buf) => {\n+ const token = buf.toString("hex");\n+ done(err, token);\n+ });\n+ },\n+ function setRandomToken(token: AuthToken, done: Function) {\n+ User.findOne({ email: req.body.email }, (err, user: any) => {\n+ if (err) { return done(err); }\n+ if (!user) {\n+ req.flash("errors", { msg: "Account with that email address does not exist." });\n+ return res.redirect("/forgot");\n+ }\n+ user.passwordResetToken = token;\n+ user.passwordResetExpires = Date.now() + 3600000; // 1 hour\n+ user.save((err: WriteError) => {\n+ done(err, token, user);\n+ });\n+ });\n+ },\n+ function sendForgotPasswordEmail(token: AuthToken, user: UserDocument, done: Function) {\n+ const transporter = nodemailer.createTransport({\n+ service: "SendGrid",\n+ auth: {\n+ user: process.env.SENDGRID_USER,\n+ pass: process.env.SENDGRID_PASSWORD\n+ }\n+ });\n+ const mailOptions = {\n+ to: user.email,\n+ from: "hackathon@starter.com",\n+ subject: "Reset your password on Hackathon Starter",\n+ text: `You are receiving this email because you (or someone else) have requested the reset of the password for your account.\\n\\n\n Please click on the following link, or paste this into your browser to complete the process:\\n\\n\n http://${req.headers.host}/reset/${token}\\n\\n\n If you did not request this, please ignore this email and your password will remain unchanged.\\n`\n- };\n- transporter.sendMail(mailOptions, (err) => {\n- req.flash("info", { msg: `An e-mail has been sent to ${user.email} with further instructions.` });\n- done(err);\n- });\n- }\n- ], (err) => {\n- if (err) { return next(err); }\n- res.redirect("/forgot");\n- });\n+ };\n+ transporter.sendMail(mailOptions, (err) => {\n+ req.flash("info", { msg: `An e-mail has been sent to ${user.email} with further instructions.` });\n+ done(err);\n+ });\n+ }\n+ ], (err) => {\n+ if (err) { return next(err); }\n+ res.redirect("/forgot");\n+ });\n };\n',
205-
id: 1088,
206-
newFile: false,
207-
newPath: 'src/controllers/user.ts',
208-
oldPath: 'src/controllers/user.ts',
209-
renamedFile: false,
210-
tooLarge: false,
211-
},
212188
lineCode: 'c17950853d6b9677e9822cf07f2616db7ca02797_388_384',
213189
lineType: 'old',
214190
note: '111 \n\n\n![image.png](/ide-s/TypeScript-Node-Starter/uploads/cd8f399b2c994d01b4afe179c26e5a4f/image.png)\n',
@@ -244,7 +220,7 @@ const App = () => {
244220
};
245221
let noteIdToNote = Array.from(commentPack.noteIdToNote.entries());
246222
// @ts-ignore
247-
noteIdToNote.push([123123123, mock]);
223+
noteIdToNote.push([400003, mock]);
248224

249225
CodeScaningPlugin.commands?.executeCommand(
250226
'antcode-cr.plugin.update.comments',

0 commit comments

Comments
 (0)