Skip to content

Commit f35b37e

Browse files
author
winjo
committed
chore: 更改部分类型及命名
1 parent 3504b02 commit f35b37e

5 files changed

Lines changed: 20 additions & 24 deletions

File tree

packages/cli/src/extension.ts

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { from, of } from 'rxjs';
55
import { mergeMap, filter } from 'rxjs/operators';
66
import { EXTENSION_DIR, EXTENSION_METADATA_DIR } from './util/constant';
77
import { getExtension } from './extension/scanner';
8-
import { IExtensionBasicMetadata, IExtensionId, IExtensionIdentity } from './extension/type';
8+
import { IExtensionBasicMetadata, IExtensionDesc, IExtensionIdentity } from './extension/type';
99
import { log, error } from './util/log';
1010
import checkFramework from './util/check-framework';
1111
import { formatExtension } from './util';
@@ -19,7 +19,7 @@ export const install = async (extensionId?: string[]) => {
1919

2020
createInstaller();
2121

22-
let extensions: IExtensionId[] = [];
22+
let extensions: IExtensionDesc[] = [];
2323

2424
if (extensionId?.length) {
2525
extensions = parseExtensionId(extensionId);
@@ -88,7 +88,7 @@ async function removeAllExtension() {
8888
await fse.ensureDir(EXTENSION_METADATA_DIR);
8989
}
9090

91-
async function removeExtensionById(ext: IExtensionId) {
91+
async function removeExtensionById(ext: IExtensionDesc) {
9292
const extensionId = `${ext.publisher}.${ext.name}`;
9393
return Promise.all([
9494
await fse.remove(
@@ -99,7 +99,7 @@ async function removeExtensionById(ext: IExtensionId) {
9999
]);
100100
}
101101

102-
async function getExtensionFromPackage(): Promise<IExtensionId[]> {
102+
async function getExtensionFromPackage(): Promise<IExtensionDesc[]> {
103103
try {
104104
const projectPkgJSON = await fse.readJSON(path.resolve('package.json'));
105105
return projectPkgJSON?.kaitianExtensions ?? [];
@@ -140,7 +140,7 @@ function checkExtensionConfig(extensions: Extension[]) {
140140
}
141141

142142
function parseExtensionId(extensionIds: string[]) {
143-
const extensions: IExtensionId[] = [];
143+
const extensions: IExtensionDesc[] = [];
144144
for (const extId of extensionIds) {
145145
const reg = /^([a-zA-Z][0-9a-zA-Z_-]*)\.([a-zA-Z][0-9a-zA-Z_-]*)(?:@(\d+\.\d+\.\d+.*))?$/;
146146
const matched = extId.match(reg);
@@ -153,7 +153,7 @@ function parseExtensionId(extensionIds: string[]) {
153153
return extensions;
154154
}
155155

156-
async function installExtension(extension: IExtensionId) {
156+
async function installExtension(extension: IExtensionDesc) {
157157
return extensionInstaller.install({
158158
publisher: extension.publisher,
159159
name: extension.name,
@@ -195,8 +195,8 @@ async function modifyPkgJSON(extensions: IExtensionIdentity[]) {
195195
// uninstall
196196
export async function uninstall(extensionId: string[]) {
197197
const extensions = await getExtensionFromPackage();
198-
const removeExtensions: IExtensionId[] = [];
199-
const remainExtensions: IExtensionId[] = [];
198+
const removeExtensions: IExtensionDesc[] = [];
199+
const remainExtensions: IExtensionDesc[] = [];
200200
for (const config of extensions) {
201201
let index = -1;
202202
for (let i = 0; i < extensionId.length; i++) {

packages/cli/src/extension/metadata-type.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ interface IExtensionBasicMetadata {
2121
}
2222
packageJSON: {
2323
name: string
24-
activationEvents: string[]
25-
kaitianContributes: any
26-
contributes: any
24+
activationEvents?: string[]
25+
kaitianContributes?: Record<string, any>
26+
contributes?: Record<string, any>
2727
}
2828
defaultPkgNlsJSON: JSONType | undefined
2929
pkgNlsJSON: JSONType

packages/cli/src/extension/type.ts

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
1+
import { Uri } from '@ali/ide-core-common';
2+
13
export { IExtensionBasicMetadata, NLS, IExtensionIdentity } from '@alipay/spacex-shared';
24

3-
export interface IExtensionId {
5+
export interface IExtensionDesc {
46
publisher: string;
57
name: string;
68
version?: string;
@@ -25,11 +27,5 @@ export interface IExtensionMetaData {
2527
extendConfig: JSONType;
2628
isBuiltin: boolean;
2729
isDevelopment?: boolean;
28-
uri?: {
29-
scheme: string;
30-
authority: string;
31-
path: string;
32-
query: string;
33-
fragment: string;
34-
};
30+
uri?: Uri;
3531
}

packages/cli/src/util/index.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { IExtensionId } from '../extension/type';
1+
import { IExtensionDesc } from '../extension/type';
22

3-
export const formatExtension = (ext: IExtensionId) =>
3+
export const formatExtension = (ext: IExtensionDesc) =>
44
`${ext.publisher}.${ext.name}${ext.version ? `@${ext.version}` : ''}`;

packages/shared/src/types.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ export interface IExtensionBasicMetadata {
2020
extension: IExtensionIdentity;
2121
packageJSON: {
2222
name: string;
23-
activationEvents: string[];
24-
kaitianContributes: any;
25-
contributes: any;
23+
activationEvents?: string[];
24+
kaitianContributes?: Record<string, any>;
25+
contributes?: Record<string, any>;
2626
};
2727
defaultPkgNlsJSON: JSONType | undefined;
2828
pkgNlsJSON: JSONType;

0 commit comments

Comments
 (0)