Skip to content

fix: dispose plugin service will cause crash#115

Merged
bytemain merged 4 commits intomainfrom
fix/dispose-plugin-service
Aug 1, 2024
Merged

fix: dispose plugin service will cause crash#115
bytemain merged 4 commits intomainfrom
fix/dispose-plugin-service

Conversation

@bytemain
Copy link
Copy Markdown
Member

@bytemain bytemain commented Aug 1, 2024

Types

  • 🐛 Bug Fixes

Background or solution

CleanShot 2024-08-01 at 14 30 08@2x

卸载组件的时候会报错

ChangeLog

fix some crashes about dispose

Summary by CodeRabbit

  • 新功能

    • 引入了 tryCatchPromise 函数,以增强异步操作的错误处理。
    • PluginService 类中添加了 dispose 方法,以改善插件的生命周期管理。
  • 改进

    • 更新了多个模块的清理逻辑,确保在调用相关方法前进行必要的检查,从而提高了应用的稳定性。
  • 错误修复

    • 改善了错误处理和日志记录功能,降低了潜在崩溃的风险。

@bytemain bytemain requested a review from Ricbet August 1, 2024 07:07
@ant-codespaces
Copy link
Copy Markdown

ant-codespaces Bot commented Aug 1, 2024

Run and Debug this pull request in Codespaces

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Aug 1, 2024

Walkthrough

Walkthrough

此次更改聚焦于增强错误处理机制,主要通过引入新的工具函数 tryCatchPromise 来改进多个组件中的异步操作管理。文件中的直接调用被封装,以确保在处置过程中捕捉异常,从而提高了系统的稳定性和可靠性。此外,插件服务的处置流程也得到了明确化,整体上提升了应用的鲁棒性。

Changes

文件路径 更改摘要
packages/core/src/api/createApp.tsx
packages/core/src/api/createEditor.tsx
tryCatchPromise 替代直接调用 disposeAll(),增强错误处理。
packages/plugin/src/plugin.contribution.ts dispose 方法中增加了对 pluginService 的检查,提升了稳健性。
packages/plugin/src/plugin.service.ts 新增 dispose() 方法以明确插件服务的清理流程。
packages/sumi-core/src/client/override/monacoOverride/contextKeyService.ts 移除 super.dispose() 调用,改变了处置逻辑。
packages/sumi-core/src/common/util.ts 新增 tryCatchPromise 工具函数,改善异步操作的错误处理。
packages/sumi-core/src/server/core/app.ts 在服务绑定和客户端通道处理函数中增强了错误处理和日志记录功能。

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@opensumi opensumi Bot added the 🐞 bug label Aug 1, 2024
@bytemain bytemain changed the title fix: dispose plugin service will cause error fix: dispose plugin service will cause crash Aug 1, 2024
@bytemain bytemain merged commit 20c11b9 into main Aug 1, 2024
@bytemain bytemain deleted the fix/dispose-plugin-service branch August 1, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants