Skip to content

Conversation

@yantze
Copy link
Member

@yantze yantze commented Sep 23, 2022

Types

  • 💄 Style Changes

Background or solution

titlebar 的高度没有撑满整个 headerbar,导致拖拽区域狭窄。
image

Changelog

修复 Electron HeaderBar 的拖动区域狭窄问题

@codecov
Copy link

codecov bot commented Sep 23, 2022

Codecov Report

Base: 57.58% // Head: 57.58% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (fc7cfbb) compared to base (4284ede).
Patch coverage: 46.24% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##            v2.20    #1714   +/-   ##
=======================================
  Coverage   57.58%   57.58%           
=======================================
  Files        1255     1255           
  Lines       78349    78375   +26     
  Branches    16406    16416   +10     
=======================================
+ Hits        45115    45134   +19     
- Misses      30237    30243    +6     
- Partials     2997     2998    +1     
Flag Coverage Δ
jsdom 52.40% <43.80%> (+<0.01%) ⬆️
node 15.82% <24.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/comments/src/common/index.ts 100.00% <ø> (ø)
packages/connection/src/node/connect.ts 100.00% <ø> (ø)
packages/core-browser/src/context-key.ts 100.00% <ø> (ø)
...browser/src/extensions/extensions-point.service.ts 29.54% <0.00%> (ø)
...core-browser/src/extensions/schema/browserViews.ts 100.00% <ø> (ø)
...ages/core-browser/src/extensions/schema/toolbar.ts 100.00% <ø> (ø)
packages/core-browser/src/monaco/index.ts 100.00% <ø> (ø)
packages/core-browser/src/opener/command-opener.ts 21.05% <ø> (ø)
packages/core-browser/src/quick-open/index.ts 77.63% <ø> (ø)
...es/core-browser/src/services/status-bar-service.ts 100.00% <ø> (ø)
... and 210 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@erha19 erha19 merged commit 3fa6625 into v2.20 Sep 23, 2022
@erha19 erha19 deleted the fix/electron-header-narrow branch September 23, 2022 07:55
yantze added a commit that referenced this pull request Sep 26, 2022
@erha19 erha19 mentioned this pull request Oct 12, 2022
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants