Skip to content

Conversation

@cgalibern
Copy link
Contributor

@cgalibern cgalibern commented Apr 3, 2025

Description

This pull request includes the following updates to the GitHub webhook and API schema:

  • Update GitHub webhook version to 0.2.1: Incremented the OpenAPI specification version, incorporating minor improvements or bug fixes while maintaining backward compatibility.
  • Make GitHub API timestamps nullable: Added nullable properties to closed_at, updated_at, and merged_at fields in the schema for scenarios where these values might not exist.
  • Update 'merged' field type: Changed the type of the merged field from bool to boolean to align with OpenAPI specifications and ensure consistency in type conventions.

This fix following 400 error when closed_at is null

{
  "detail": "None is not of type 'string' - 'pull_request.closed_at'",
 "status": 400,
 "title": "Bad Request",
 "type": "about:blank"
}

Changed the field type of 'merged' from 'bool' to 'boolean' to ensure consistency with OpenAPI specification.
This aligns the schema with standard data type conventions.
Added nullable property to 'closed_at', 'updated_at', and 'merged_at' fields in the GitHub API YAML definition.
This ensures compatibility with scenarios where these fields might not have a value.
Incremented the OpenAPI specification version in the GitHub webhook receiver descriptor.
This update likely includes minor improvements or bug fixes while maintaining backward compatibility.
@cgalibern cgalibern merged commit fd970aa into opensvc:main Apr 3, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant