feat(sdk): EC-wrapped key support for ZTDF #224
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkleene
reviewed
Feb 26, 2025
Contributor
mkleene
left a comment
mkleene
left a comment
There was a problem hiding this comment.
Looks good. The only thing that I really think that we should change is
- we generate an EC keypair for every request
- if we are doing EC then we generate an RSA keypair that's unused
sdk/src/main/java/io/opentdf/platform/sdk/nanotdf/ECKeyPair.java
Outdated
Show resolved
Hide resolved
mkleene
reviewed
Feb 26, 2025
mkleene
approved these changes
Feb 26, 2025
Contributor
mkleene
left a comment
mkleene
left a comment
There was a problem hiding this comment.
Looks good! Just one comment on thread safety.
pflynn-virtru
approved these changes
Feb 28, 2025
|
mkleene
pushed a commit
that referenced
this pull request
Apr 7, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>0.7.7</summary> ## [0.7.7](v0.7.6...v0.7.7) (2025-04-07) ### Features * **sdk:** EC-wrapped key support for ZTDF ([#224](#224)) ([d062691](d062691)) ### Bug Fixes * **cmdline:** Disable failing encryptnano ecdsa ([#227](#227)) ([80ca207](80ca207)) * **cmdline:** Enable ec-wrapped cfg ([#231](#231)) ([ee39ed5](ee39ed5)) * if a version < 4.3.0 is specified create an old-style TDF ([#234](#234)) ([082a9e7](082a9e7)) * **sdk:** Fixes nano ECDSA policy binding config ([#225](#225)) ([f3e9fed](f3e9fed)) * **sdk:** Remove temporary ec salt value ([#228](#228)) ([0fe37c6](0fe37c6)) * **sdk:** Set ec-wrapped to new salt value ([#230](#230)) ([d3be28e](d3be28e)) * **sdk:** Update version information ([#232](#232)) ([f9eeb0d](f9eeb0d)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
ec-wrappedKAO type that uses a hybrid EC encryption scheme to wrap the valuesWithWrappingKeyAlgandWithSessionKeyTypefunctional optionChecklist