Skip to content

fix: if a version < 4.3.0 is specified create an old-style TDF #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 7, 2025
Merged

fix: if a version < 4.3.0 is specified create an old-style TDF #234

merged 15 commits into from
Apr 7, 2025

Conversation

@mkleene
Copy link
Contributor

@mkleene mkleene commented Apr 4, 2025 •
edited
Loading

If a version less than 4.3.0 is specified:

  • encode hashes using a layer of hex-encoding
  • leave version information out of the manifest

@mkleene mkleene changed the title Feature/hash compat fix: if a version < 4.3.0 is specified create an old-style TDF Apr 4, 2025
@mkleene mkleene marked this pull request as ready for review April 4, 2025 19:35
@mkleene mkleene requested review from a team as code owners April 4, 2025 19:35
pflynn-virtru
pflynn-virtru previously approved these changes Apr 4, 2025
View reviewed changes
strantalis
strantalis requested changes Apr 7, 2025
View reviewed changes
@mkleene mkleene requested a review from strantalis April 7, 2025 15:56
@strantalis strantalis requested a review from Copilot April 7, 2025 16:03
Copilot AI reviewed Apr 7, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 7, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@mkleene mkleene merged commit 082a9e7 into main Apr 7, 2025
8 of 9 checks passed
@mkleene mkleene deleted the feature/hash-compat branch April 7, 2025 18:28
@opentdf-automation opentdf-automation bot mentioned this pull request Apr 7, 2025
Merged
mkleene pushed a commit that referenced this pull request Apr 7, 2025
@opentdf-automation
chore(main): release 0.7.7 (#226)
d278a3d 
🤖 I have created a release *beep* *boop*
---


<details><summary>0.7.7</summary>

## [0.7.7](v0.7.6...v0.7.7)
(2025-04-07)


### Features

* **sdk:** EC-wrapped key support for ZTDF
([#224](#224))
([d062691](d062691))


### Bug Fixes

* **cmdline:** Disable failing encryptnano ecdsa
([#227](#227))
([80ca207](80ca207))
* **cmdline:** Enable ec-wrapped cfg
([#231](#231))
([ee39ed5](ee39ed5))
* if a version &lt; 4.3.0 is specified create an old-style TDF
([#234](#234))
([082a9e7](082a9e7))
* **sdk:** Fixes nano ECDSA policy binding config
([#225](#225))
([f3e9fed](f3e9fed))
* **sdk:** Remove temporary ec salt value
([#228](#228))
([0fe37c6](0fe37c6))
* **sdk:** Set ec-wrapped to new salt value
([#230](#230))
([d3be28e](d3be28e))
* **sdk:** Update version information
([#232](#232))
([f9eeb0d](f9eeb0d))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@strantalis strantalis strantalis approved these changes

@pflynn-virtru pflynn-virtru pflynn-virtru left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mkleene @strantalis @pflynn-virtru