-
Notifications
You must be signed in to change notification settings - Fork 2
ci: SonarCloud coverage #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a new Maven profile for JaCoCo test coverage reporting in the `pom.xml`. Additionally, update the GitHub Actions workflow to include a SonarCloud scan that uses the JaCoCo coverage data.
This commit adds necessary properties for integrating SonarCloud to the Maven coverage profile. It includes organization, project key, and host URL settings for SonarCloud.
Upgraded JDK version from 11 to 17 and changed the distribution from 'adopt' to 'temurin' in the checks workflow. This ensures compatibility with newer Java features and improves build stability.
Update the CI workflow to run `mvn clean verify` instead of `mvn clean sonar:sonar`. This ensures that the build verification process is executed, aligning the workflow with standard Maven practices.
Included SDK module in the coverage profile and added multiple reporting phases in the Maven Surefire plugin. This enhances the testing process by generating and aggregating coverage reports at different stages of the build lifecycle.
This integrates the Buf setup action in the checks workflow. The action will be configured using the GitHub token for authentication. This change ensures proper configuration for projects using Buf.
This commit integrates the Jacoco Maven plugin into the project for better code coverage reporting. It configures specific goals and phases to prepare the agent and generate XML reports during the test phase. This change enhances code quality monitoring and facilitates thorough testing practices.
pflynn-virtru
commented
Oct 16, 2024
This commit adds the 'sonarcloud' job to the CI workflow file. SonarCloud will help in tracking code quality and identifying potential issues early. It runs alongside existing jobs to ensure comprehensive code analysis during CI checks.
|
dmihalcik
approved these changes
Oct 16, 2024
|
d'oh |
dmihalcik-virtru
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Introduce a new Maven profile for JaCoCo test coverage reporting in the
pom.xml. Additionally, update the GitHub Actions workflow to include a SonarCloud scan that uses the JaCoCo coverage data.DSP-119
DSP-120