fix(core)!: remove NanoTDF support#736
Conversation
Remove nano-specific CLI flags, handler paths, docs, and e2e tests.
Summary of ChangesHello @strantalis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request undertakes a significant cleanup by entirely removing NanoTDF support from the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request removes support for NanoTDF across the codebase, including from encryption, decryption, and inspection functionalities. The changes also cover the removal of related command-line flags, documentation, and end-to-end tests. The modifications are extensive and consistently applied. My review found one minor issue regarding a removed linter directive that could potentially cause CI failures. Overall, the PR effectively achieves its goal of removing NanoTDF support.
|
can we update the conventional commit that this ia a breaking change |
strantalis
changed the title
🤖 I have created a release *beep* *boop* --- ## [0.29.0](v0.28.0...v0.29.0) (2026-01-28) ### ⚠ BREAKING CHANGES * **core:** remove NanoTDF support ([#736](#736)) ### Features * **core:** Add allow_traversal to attribute defs. ([#739](#739)) ([63d71b0](63d71b0)) ### Bug Fixes * **core:** obligations commands id and fqn flag exclusivity ([#731](#731)) ([77ebbb4](77ebbb4)), closes [#728](#728) * **core:** remove NanoTDF support ([#736](#736)) ([9528821](9528821)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: opentdf-automation[bot] <149537512+opentdf-automation[bot]@users.noreply.github.com>
NanoTDF support was removed from otdfctl in opentdf/otdfctl#736. The --tdf-type nano flag is no longer a valid value, causing all nano-related e2e tests to fail with "unknown TDF type". Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
## Summary - NanoTDF support was removed from `otdfctl` in opentdf/otdfctl#736 (Jan 2026) - `--tdf-type nano` is no longer a valid value, causing 5 e2e tests to fail with `unknown TDF type` across all PRs that run integration tests - Removes the 5 affected nanoTDF bats test cases from `tests/bats/e2e.bats` ## Test plan - [ ] Verify integration tests pass with the nano test cases removed - [ ] Confirm remaining TDF3 encrypt/decrypt tests still run and pass 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Tests** * Removed end-to-end test cases for nanoTDF encryption and decryption operations. TDF3 tests remain unchanged. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
3 participants
Remove NanoTDF ("nano" tdf-type) support from encrypt/decrypt/inspect, docs, and e2e coverage. This drops nano-only flags like --ecdsa-binding and --policy-mode. Tests: go test ./... -short -race -cover; golangci-lint run; go build ./....