fix: Go 1.25 by pflynn-virtru · Pull Request #3053 · opentdf/platform

pflynn-virtru · 2026-02-06T19:52:47Z

Summary

Upgrades go directive to 1.25.0 and toolchain to go1.25.7 in all workspace modules and go.work
Addresses GO-2026-4337 (crypto/tls vulnerability, fixed in go1.25.7)
Updates golangci-lint from v2.1 to v2.8.0 in CI workflow and Makefile (required for Go 1.25 compatibility)
Updates govulncheck go-version-input to 1.25.7 in checks.yaml and vulnerability-check.yaml
Updates sonarcloud.yml Go version from 1.23 to 1.25.7

Test plan

go mod tidy succeeds in all modules
go build ./... succeeds in all modules
CI checks pass

🤖 Generated with Claude Code

gemini-code-assist · 2026-02-06T19:53:01Z

Summary of Changes

Hello @pflynn-virtru, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the Go development environment by upgrading the Go toolchain and language version across the entire project. This ensures that all modules are built with the latest stable Go release, benefiting from performance improvements, new features, and critical security patches, particularly addressing a known vulnerability in the crypto/tls package.

Highlights

Go Toolchain Upgrade: The Go toolchain has been upgraded to version 1.25.5 across all modules within the repository, including the go.work file.
Go Directive Update: The go directive in all go.mod files has been updated to 1.25 to reflect the new Go language version.
Vulnerability Remediation: This upgrade specifically addresses the crypto/tls vulnerability identified as GO-2026-4337, improving the security posture of the platform.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

examples/go.mod
- Updated go directive from 1.24.0 to 1.25.
- Updated toolchain directive from go1.24.11 to go1.25.5.
go.work
- Updated the global go version from 1.24.11 to 1.25.5.
lib/fixtures/go.mod
- Updated go directive from 1.23.0 to 1.25.
- Updated toolchain directive from go1.24.11 to go1.25.5.
lib/flattening/go.mod
- Updated go directive from 1.23 to 1.25.
- Added toolchain go1.25.5 directive.
lib/identifier/go.mod
- Updated go directive from 1.23 to 1.25.
- Added toolchain go1.25.5 directive.
lib/ocrypto/go.mod
- Updated go directive from 1.24.0 to 1.25.
- Updated toolchain directive from go1.24.11 to go1.25.5.
sdk/go.mod
- Updated go directive from 1.24.0 to 1.25.
- Updated toolchain directive from go1.24.11 to go1.25.5.
service/go.mod
- Updated go directive from 1.24.0 to 1.25.
- Updated toolchain directive from go1.24.11 to go1.25.5.
tests-bdd/go.mod
- Updated go directive from 1.24.11 to 1.25.
- Added toolchain go1.25.5 directive.

Ignored Files

Ignored by pattern: protocol/**/* (1)
- protocol/go/go.mod

Activity

The pull request was automatically generated by Claude Code.
The author has confirmed that go mod tidy and go build ./... succeed in all modules as part of the test plan.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

New Go version springs, Security, swift and strong, Code now safer runs.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request upgrades the Go toolchain to 1.25.5 across multiple modules to address a security vulnerability. The changes in the go.mod files are correct. I've added a suggestion to go.work to improve consistency with the other files. A potential issue is that the protocol/go module, listed in go.work, does not seem to be updated. To ensure project-wide consistency and prevent potential build issues, its go.mod file should also be updated to use the new Go version and toolchain.

go.work

github-actions · 2026-02-06T20:04:17Z

X-Test Failure Report

opentdf~~platform~~QXRL33.dockerbuild

github-actions · 2026-02-06T20:04:56Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	195.234376ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	105.899242ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	365.184417ms
Throughput	273.83 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.16311691s
Average Latency	390.26041ms
Throughput	127.67 requests/second

github-actions · 2026-02-06T20:05:55Z

X-Test Failure Report

opentdf~~platform~~P7AMVI.dockerbuild

github-actions · 2026-02-06T20:07:03Z

X-Test Failure Report

github-actions · 2026-02-06T20:09:37Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	191.566725ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	106.690314ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	369.607096ms
Throughput	270.56 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.132097872s
Average Latency	388.792051ms
Throughput	127.77 requests/second

github-actions · 2026-02-06T20:09:44Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	197.456628ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	106.444836ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	374.298656ms
Throughput	267.17 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.320814639s
Average Latency	391.062029ms
Throughput	127.16 requests/second

github-actions · 2026-02-06T20:11:31Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	196.968464ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	111.597606ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	370.484623ms
Throughput	269.92 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	40.330458697s
Average Latency	401.801071ms
Throughput	123.98 requests/second

github-actions · 2026-02-06T20:13:58Z

X-Test Failure Report

opentdf~~platform~~PGYSQI.dockerbuild
❌ js-v0.9.0
cukes-report

github-actions · 2026-02-06T20:14:37Z

X-Test Failure Report

github-actions · 2026-02-06T20:18:03Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	196.841864ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	102.927133ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	370.04031ms
Throughput	270.24 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.12871722s
Average Latency	389.606223ms
Throughput	127.78 requests/second

github-actions · 2026-02-06T20:18:52Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	208.95466ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	110.655965ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	369.6325ms
Throughput	270.54 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	40.217763108s
Average Latency	400.691158ms
Throughput	124.32 requests/second

github-actions · 2026-02-06T20:20:15Z

X-Test Failure Report

opentdf~~platform~~SEU390.dockerbuild

github-actions · 2026-02-06T20:23:58Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	188.177228ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	102.089495ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	366.265836ms
Throughput	273.03 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	39.369503265s
Average Latency	392.095186ms
Throughput	127.00 requests/second

.github/workflows/sonarcloud.yml

github-actions · 2026-02-06T20:31:18Z

X-Test Failure Report

opentdf~~platform~~C27SJC.dockerbuild
❌ js-v0.9.0
cukes-report
❌ java-v0.9.0
✅ js-pull-3053
bats-test-results
test-cases-mapping-report
✅ java-pull-3053
❌ go-v0.9.0
✅ go-pull-3053

Addresses GO-2026-4337 (crypto/tls vulnerability) by upgrading the go directive to 1.25 and toolchain to go1.25.5 in all workspace modules. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Paul Flynn <pflynn@virtru.com>

github-actions · 2026-02-06T20:41:11Z

X-Test Failure Report

opentdf~~platform~~C27SJC.dockerbuild
❌ js-v0.9.0
cukes-report
❌ java-v0.9.0
✅ js-pull-3053
bats-test-results
test-cases-mapping-report
✅ java-pull-3053
❌ go-v0.9.0
✅ go-pull-3053
❌ js-v0.9.0
❌ java-v0.9.0

github-actions · 2026-02-06T20:45:32Z

Benchmark results, click to expand

Benchmark authorization.GetDecisions Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	197.455292ms

Benchmark authorization.v2.GetMultiResourceDecision Results:

Metric	Value
Approved Decision Requests	1000
Denied Decision Requests	0
Total Time	108.297788ms

Benchmark Statistics

Name	№ Requests	Avg Duration	Min Duration	Max Duration

Bulk Benchmark Results

Metric	Value
Total Decrypts	100
Successful Decrypts	100
Failed Decrypts	0
Total Time	375.900214ms
Throughput	266.03 requests/second

TDF3 Benchmark Results:

Metric	Value
Total Requests	5000
Successful Requests	5000
Failed Requests	0
Concurrent Requests	50
Total Time	41.635641756s
Average Latency	414.420009ms
Throughput	120.09 requests/second

github-actions · 2026-02-06T20:52:13Z

X-Test Failure Report

opentdf~~platform~~SR8IBK.dockerbuild
cukes-report
❌ js-v0.9.0
❌ java-v0.9.0
✅ js-pull-3053
bats-test-results
test-cases-mapping-report
✅ java-pull-3053
❌ go-v0.9.0
✅ go-pull-3053

github-actions · 2026-02-09T13:07:21Z

X-Test Results

opentdf~~platform~~SR8IBK.dockerbuild
cukes-report
❌ js-v0.9.0
❌ java-v0.9.0
✅ js-pull-3053
bats-test-results
test-cases-mapping-report
✅ java-pull-3053
❌ go-v0.9.0
✅ go-pull-3053
✅ js-v0.9.0
✅ java-v0.9.0
✅ go-v0.9.0

pflynn-virtru requested review from a team as code owners February 6, 2026 19:52

github-actions bot added comp:sdk A software development kit, including library, for client applications and inter-service communicati comp:examples comp:lib:fixtures comp:lib:flattening comp:lib:ocrypto size/s labels Feb 6, 2026

gemini-code-assist bot reviewed Feb 6, 2026

View reviewed changes

go.work Outdated Show resolved Hide resolved

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch 2 times, most recently from c300e21 to 32b224e Compare February 6, 2026 20:03

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from 32b224e to 8094388 Compare February 6, 2026 20:05

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from 8094388 to be1037f Compare February 6, 2026 20:06

pflynn-virtru changed the title ~~fix: upgrade Go toolchain to 1.25.5 across all modules~~ fix: Go 1.25 Feb 6, 2026

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from be1037f to fa3e24b Compare February 6, 2026 20:13

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from fa3e24b to 6f0ef80 Compare February 6, 2026 20:14

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from 6f0ef80 to cf4e09b Compare February 6, 2026 20:19

pflynn-virtru enabled auto-merge February 6, 2026 20:22

elizabethhealy reviewed Feb 6, 2026

View reviewed changes

.github/workflows/sonarcloud.yml Outdated Show resolved Hide resolved

pflynn-virtru force-pushed the fix/upgrade-go-toolchain branch from cf4e09b to a0af3eb Compare February 6, 2026 20:40

elizabethhealy approved these changes Feb 6, 2026

View reviewed changes

dmihalcik-virtru approved these changes Feb 9, 2026

View reviewed changes

strantalis approved these changes Feb 9, 2026

View reviewed changes

pflynn-virtru added this pull request to the merge queue Feb 9, 2026

Merged via the queue into main with commit 65eb7c3 Feb 9, 2026
65 of 70 checks passed

pflynn-virtru deleted the fix/upgrade-go-toolchain branch February 9, 2026 15:33

Conversation

pflynn-virtru commented Feb 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

gemini-code-assist bot commented Feb 6, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

Bulk Benchmark Results

TDF3 Benchmark Results:

Uh oh!

github-actions bot commented Feb 6, 2026

X-Test Failure Report

Uh oh!

github-actions bot commented Feb 6, 2026

Benchmark authorization.GetDecisions Results:

Benchmark authorization.v2.GetMultiResourceDecision Results:

Benchmark Statistics

pflynn-virtru commented Feb 6, 2026 •

edited

Loading