fix(sdk): require at least one FQN in ForAttributeValues#3355
fix(sdk): require at least one FQN in ForAttributeValues#3355marythought merged 1 commit intomainfrom
Conversation
Add a panic guard for zero-argument calls to ForAttributeValues, aligning with the Java SDK's IllegalArgumentException and the proto's 1-20 FQN constraint. Callers passing zero FQNs now get a clear error instead of a silently invalid Resource. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Mary Dickson <mary.dickson@virtru.com>
|
Note Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported. |
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 58 minutes and 7 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Benchmark results, click to expandBenchmark authorization.GetDecisions Results:
Benchmark authorization.v2.GetMultiResourceDecision Results:
Benchmark Statistics
Bulk Benchmark Results
TDF3 Benchmark Results:
|
|
Summary
ForAttributeValuesIllegalArgumentExceptionguard and the proto'sfqns.size() > 0constraintTest plan
TestForAttributeValues_ZeroArgs_Panicsverifies the panicgolangci-lintclean🤖 Generated with Claude Code