Skip to content

Conversation

Arthurdw
Copy link
Contributor

Fixes a parameter name conflict in RetryAsyncSubstrate._retry() and RetrySyncSubstrate._retry() that
caused TypeError: got multiple values for argument 'method' when calling methods like
runtime_call() with keyword arguments.

The _retry() wrapper method used a parameter named method, which conflicted with wrapped methods
that also have a method parameter. Renamed the parameter to method_name to avoid the collision.

Added regression tests to ensure runtime_call() works correctly with keyword arguments in both retry
substrate classes.

@thewhaleking thewhaleking self-requested a review October 21, 2025 17:17
Copy link
Collaborator

@thewhaleking thewhaleking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@thewhaleking thewhaleking merged commit 06f4bcc into opentensor:staging Oct 21, 2025
32 of 35 checks passed
@thewhaleking thewhaleking mentioned this pull request Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants