Fix parameter name conflict in retry substrate _retry() methods #218
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a parameter name conflict in
RetryAsyncSubstrate._retry()
andRetrySyncSubstrate._retry()
thatcaused
TypeError: got multiple values for argument 'method'
when calling methods likeruntime_call()
with keyword arguments.The
_retry()
wrapper method used a parameter namedmethod
, which conflicted with wrapped methodsthat also have a
method
parameter. Renamed the parameter tomethod_name
to avoid the collision.Added regression tests to ensure
runtime_call()
works correctly with keyword arguments in both retrysubstrate classes.