Skip to content

Conversation

@sam0x17
Copy link
Contributor

@sam0x17 sam0x17 commented Nov 14, 2025

@sam0x17 sam0x17 self-assigned this Nov 14, 2025
@sam0x17 sam0x17 added hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet skip-cargo-audit This PR fails cargo audit but needs to be merged anyway deploy-mainnet labels Nov 14, 2025
@sam0x17 sam0x17 changed the title hotfix 11/14/2025 hotfix 11/17/2025 Nov 17, 2025
* clamp at values given to/taken from the user

* spec bump

* use min instead of clamp

* overstate the outflow

* update comments
@sam0x17 sam0x17 requested a review from a team November 17, 2025 23:56
Copy link
Contributor

@camfairchild camfairchild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a

@sam0x17
Copy link
Contributor Author

sam0x17 commented Nov 18, 2025

btw the CI failures are ci glitching out, this branch passes

@sam0x17 sam0x17 changed the title hotfix 11/17/2025 hotfix 11/18/2025 Nov 18, 2025
@camfairchild camfairchild self-requested a review November 18, 2025 16:35
@sam0x17 sam0x17 merged commit 6304dbe into main Nov 18, 2025
109 of 122 checks passed
@Swamination-Yuma
Copy link

I request that all PRs have actual descriptions of the issue and the resolution. They do not have to be verbose, but PRs are not transparent to the community readily without reading code. It also helps non-approvers who are reviewing to know if it actually meets the need or raises concerns. It also provides history of the mindset of the product. The PR template is mostly ignored atm. Approvers should require this, imo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-mainnet hotfix This PR needs to be merged very quickly and will likely skip testing on devnet and testnet skip-cargo-audit This PR fails cargo audit but needs to be merged anyway

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants