Root claim upgrade (part 1) #2218
Merged
+342
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shamil-gadelshin
added
the
skip-cargo-audit
l0r1s
reviewed
Nov 20, 2025
l0r1s
reviewed
Nov 20, 2025
Comment on lines
+1612
to
+1620
| let validator_take_percent = 0.18f64; | ||
| let estimated_root_claim_dividends = | ||
| (pending_root_alpha as f64) * (1f64 - validator_take_percent); | ||
|
|
||
| assert_abs_diff_eq!( | ||
| estimated_root_claim_dividends as u64, | ||
| u64::from(root_claim_dividends1), | ||
| epsilon = 100u64, | ||
| ); |
Collaborator
There was a problem hiding this comment.
If we want to avoid precision loss, you could use Percent. This is only a test though
Collaborator
Author
There was a problem hiding this comment.
I would keep it. Conversion operations seem simpler.
l0r1s
previously approved these changes
Nov 20, 2025
l0r1s
previously approved these changes
Nov 21, 2025
l0r1s
approved these changes
Nov 25, 2025
sam0x17
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a batch of root claim upgrades:
RootClaimTypeEnumwith a new settingKeepSubnets. It enables an option to setKeeponly to specific subnets and to treat all other subnets asSwapset_root_claim_typeto proxy filterRootAlphaDividendsPerSubnetstorage map for bookkeepingType of Change
Checklist
./scripts/fix_rust.shto ensure my code is formatted and linted correctly