Skip to content

Conversation

@TC-twwang
Copy link
Contributor

@TC-twwang TC-twwang commented Mar 7, 2023

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@zzcr zzcr merged commit 7b95423 into opentiny:dev Mar 13, 2023
--ti-mobile-input-disabled-color: var(--ti-mobile-base-color-placeholder, #999);
--ti-mobile-input-disabled-bgcolor: var(--ti-mobile-base-color-selected-background, #f5f5f5);
--ti-mobile-input-exceed-color: var(--ti-mobile-base-color-danger-normal, #f5222d);
--ti-mobile-input-color-disabled: var(--ti-mobile-base-color-placeholder, #999);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ti-mobile-input-color-disabled这个命名不符合规范,因为此变量用于color或fill属性,按照命名规范,建议整改成--ti-mobile-input-text-color-disabled或--ti-mobile-input-fill-color-disabled

--ti-mobile-textarea-inner-font-size: 16px;
--ti-mobile-textarea-inner-color: var(--ti-mobile-base-color-secondary, #666);
--ti-mobile-textarea-inner-text-color: var(--ti-mobile-base-color-secondary, #666);
--ti-mobile-textarea-inner-placeholder-color: #ccc;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--ti-mobile-textarea-inner-placeholder-color也是一样的问题

@kagol kagol added the enhancement New feature or request label Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants