Skip to content

fix(chart): fix chart bug, resolve memory leakage issues #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Jul 28, 2025
Merged

fix(chart): fix chart bug, resolve memory leakage issues #3610

Changes from all commits
Commits
Show all changes
29 commits
Select commit Hold shift + click to select a range
12ed2e5
fix: 【Charts】update charts snapshots
Davont May 20, 2024
049e055
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont May 21, 2024
e002b99
fix: 修复图表height为100%时的高度问题
Davont May 22, 2024
94a15eb
fix: 优化图表extend逻辑
Davont May 22, 2024
c411a5e
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jun 3, 2024
fe1d231
fix: 修复图表extend失效问题
Davont Jun 3, 2024
8fdc5c5
fix: 删除注释
Davont Jun 3, 2024
7e4e830
fix: 新增图表echartOption变量，以便用户获取echart配置
Davont Jun 5, 2024
19052b2
fix: 修复playground百度地图案例错误问题
Davont Jun 21, 2024
9c98733
fix: 修复图表option复杂变量失效问题
Davont Jun 21, 2024
256dae7
fix: 修改高德百度地图案例注释
Davont Jun 25, 2024
c77eac6
Merge branch 'dev' into dev
Davont Jun 26, 2024
85fc901
fix: chart-core添加cloneDeep引入
Davont Jun 28, 2024
613c9e7
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jul 1, 2024
38227ec
fix: 修改chart组件getFormatted函数判断逻辑
Davont Jul 1, 2024
16bf480
fix: 更新chart-core包版本为3.17.1
Davont Jul 2, 2024
3a582f7
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Jul 11, 2024
4bb16ed
fix: 修复箱型图data为空数组时的报错问题
Davont Jul 11, 2024
d640562
fix: 添加图标属性逻辑的深拷贝
Davont Jul 11, 2024
9c2424d
fix: 删除注释文件
Davont Jul 11, 2024
fc4544f
fix: 修改图表打包
Davont Oct 22, 2024
6ef939b
fix: 图表打包指令修改
Davont Oct 23, 2024
ea0b581
Merge branch 'opentiny:dev' into dev
Davont Oct 25, 2024
804b0e6
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Dec 4, 2024
77a9acb
fix: huiCharts打包替换为Chart
Davont Dec 6, 2024
364f3d1
Merge branch 'dev' of github.com:opentiny/tiny-vue into dev
Davont Feb 18, 2025
de9b78f
Merge branch 'opentiny:dev' into dev
Davont Mar 5, 2025
1e1cd6c
fix: 新增图表解绑，解决内存泄漏问题
Davont Jul 23, 2025
68fbafd
Merge branch 'dev' of github.com:Davont/tiny-vue into dev
Davont Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/vue/src/huicharts/huicharts-core/src/chart-core.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,8 @@ export default {
this.afterSetOptionOnce && this.afterSetOptionOnce(this.integrateChart.echartsIns)
},
beforeUnmount() {
this.integrateChart = null
if (this.integrateChart.uninstall) this.integrateChart.uninstall()
Comment on lines +582 to +583
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Critical bug: Setting integrateChart to null before calling uninstall method

The current code sets this.integrateChart = null before attempting to call this.integrateChart.uninstall(). This will cause a TypeError when trying to access the uninstall property on null, and the cleanup method will never execute, potentially causing the memory leakage issues mentioned in the PR objectives.

Apply this diff to fix the cleanup order:

-    this.integrateChart = null
-    if (this.integrateChart.uninstall) this.integrateChart.uninstall()
+    if (this.integrateChart && this.integrateChart.uninstall) {
+      this.integrateChart.uninstall()
+    }
+    this.integrateChart = null
🤖 Prompt for AI Agents 
In packages/vue/src/huicharts/huicharts-core/src/chart-core.ts at lines 582-583,
the code sets this.integrateChart to null before calling its uninstall method,
causing a TypeError. To fix this, first check if this.integrateChart and its
uninstall method exist, call uninstall if so, and only then set
this.integrateChart to null to ensure proper cleanup without errors.

this.watchToPropsEchartOptions.forEach((unwatch) => {
unwatch && unwatch()
})
Expand Down
Loading