Skip to content

Conversation

@chenxi-20
Copy link
Collaborator

@chenxi-20 chenxi-20 commented Sep 8, 2025

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Bug Fixes
    • Fixed tag click behavior: selectable tags now respond to clicks and toggle selection as expected.
    • Disabled tags remain non-interactive, preserving intended behavior.
    • Closing a tag via its close action is unaffected.

@chenxi-20 chenxi-20 added the bug Something isn't working label Sep 8, 2025
@coderabbitai
Copy link

coderabbitai bot commented Sep 8, 2025

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/tag-20250908

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
packages/renderless/src/tag/index.ts (1)

27-32: Add tests to lock desired behavior (desktop + mobile)

Recommend adding unit/e2e tests to cover:

  • selectable=true: toggles selected on click; emits click.
  • selectable=false: does not toggle; still emits click.
  • disabled=true: no toggle; no emit.
  • inside group with tagSelectable=true: toggles and stops propagation.

I can provide test scaffolds for your test stack if helpful.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a68ee02 and a354597.

📒 Files selected for processing (1)
  • packages/renderless/src/tag/index.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: PR E2E Test (pnpm test:e2e3)
🔇 Additional comments (1)
packages/renderless/src/tag/index.ts (1)

27-32: Remove the props.selectable check—no such prop exists
ITagRenderlessParams.props does not define selectable in packages/renderless/types/tag.type.ts, so tightening the guard on props.selectable cannot be applied.

Likely an incorrect or invalid review comment.

@zzcr zzcr merged commit 84e0bfa into dev Sep 9, 2025
10 of 11 checks passed
@zzcr zzcr deleted the fix/tag-20250908 branch September 9, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants